This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Clang from 00396e6a1a0b to b3a9e8f7c0af#48563
Closed
skia-flutter-autoroll wants to merge 1 commit into
Closed
Conversation
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/clang-flutter-engine Please CC matanl@google.com,rmistry@google.com,zanderso@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added
the
autosubmit
skia-flutter-autoroll
force-pushed
the
clang-flutter-engine-8b57dbd5-0233-4fb1-96f5-ad7fe100bbbf-1701421092
branch
from
981f089 to
57f4e61
Compare
fluttergithubbot
approved these changes
Dec 1, 2023
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/48563, due to - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
skia-flutter-autoroll
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/48563, due to - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
skia-flutter-autoroll
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/48563, due to - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
Bot
removed
the
autosubmit
Contributor
Author
|
Commit queue failed; closing this roll. |
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Dec 5, 2023
I was shocked this was even legal earlier. But a new Clang roll makes this an a warning which gets converted into an error. I attempted to roll to the Clang roll the roller did and fixed the issues I found. Hopefully, the next roll is unblocked. Original failure: flutter-team-archive#48563
auto-submit Bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
I was shocked this was even legal earlier. But a new Clang roll makes this an a warning which gets converted into an error. I attempted to roll to the Clang roll the roller did and fixed the issues I found. Hopefully, the next roll is unblocked. Original failure: #48563
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Dec 5, 2023
Previously attempted by flutter-team-archive#48563 but failed because of fixes needed in flutter-team-archive#48693
skia-flutter-autoroll
deleted the
clang-flutter-engine-8b57dbd5-0233-4fb1-96f5-ad7fe100bbbf-1701421092
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zanderso@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md