Roll goldctl forward#46771
Conversation
vashworth
left a comment
vashworth
left a comment
There was a problem hiding this comment.
Ran it on macOS 13 and it appears to have fixed the issue! Thank you @zanderso!
https://chromium-swarm.appspot.com/task?id=6537fecff3544710
Should we also update the goldctl version here?
https://github.com/flutter/engine/blob/ec1d0d69fcf11aa64a271a1fe2f582df37f3f2e9/lib/web_ui/dev/generate_builder_json.dart#L152
zanderso
force-pushed
the
roll-goldctl
branch
from
a448031 to
bf18e63
Compare
Great!
Yes =) Thanks. I had made that change locally and forgot to push it. |
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM! Thank you!
We should probably create a cadence for rolling this forward more regularly. We pinned it since sometimes goldctl would (rarely) have a bad build and then we would then be broken in the meantime. @godofredoc do we have other systems in place that roll dependencies forward like this?
zanderso
added
the
autosubmit
flutter-team-archive/engine@68a8ff7...ed67e8a 2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (flutter-team-archive/engine#46778) 2023-10-11 zanderso@users.noreply.github.com Roll goldctl forward (flutter-team-archive/engine#46771) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from mLc-VlVTg-p1 to Qjz4zE4Oe0AO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
For flutter/flutter#135620