Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use mac arm64 clang in m1 machines.#46697

Closed
godofredoc wants to merge 4 commits into
flutter-team-archive:mainfrom
godofredoc:use_arm64_clang
Closed

Use mac arm64 clang in m1 machines.#46697
godofredoc wants to merge 4 commits into
flutter-team-archive:mainfrom
godofredoc:use_arm64_clang

Conversation

@godofredoc

Copy link
Copy Markdown
Contributor

This will use clang arm64 in builds running on mac m1 machines for builds that are not using goma.

Bug: flutter/flutter#136219

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This will use clang arm64 in builds running on mac m1 machines for
builds that are not using goma.

Bug: flutter/flutter#136219
@chinmaygarde

Copy link
Copy Markdown
Contributor

@zanderso Does this look good to go?

@zanderso

Copy link
Copy Markdown
Contributor

@godofredoc Is this PR stale?

@chinmaygarde

Copy link
Copy Markdown
Contributor

Closing this as stale. Please re-open if there is progress.

@godofredoc godofredoc deleted the use_arm64_clang branch January 12, 2024 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants