Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Don't define CanvasRecorder if IMPELLER_TRACE_CANVAS is not set. #46476

Merged
auto-submit merged 1 commit into from
Oct 4, 2023
Merged

[Impeller] Don't define CanvasRecorder if IMPELLER_TRACE_CANVAS is not set. #46476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions impeller/aiks/canvas_recorder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ enum CanvasRecorderOp : uint16_t {
DrawAtlas,
};

// Canvas recorder should only be used when IMPELLER_TRACE_CANVAS is defined
// (never in production code).
#ifdef IMPELLER_TRACE_CANVAS
/// Static polymorphic replacement for impeller::Canvas that records methods
/// called on an impeller::Canvas and forwards it to a real instance.
/// TODO(https://github.com/flutter/flutter/issues/135718): Move this recorder
Expand All @@ -55,12 +58,6 @@ enum CanvasRecorderOp : uint16_t {
template <typename Serializer>
class CanvasRecorder {
public:
#ifndef IMPELLER_TRACE_CANVAS
// Canvas recorder should only be used when IMPELLER_TRACE_CANVAS is defined
// (never in production code).
static_assert(false);
#endif

CanvasRecorder() : canvas_() { serializer_.Write(CanvasRecorderOp::New); }

explicit CanvasRecorder(Rect cull_rect) : canvas_(cull_rect) {
Expand Down Expand Up @@ -286,5 +283,6 @@ class CanvasRecorder {
Canvas canvas_;
Serializer serializer_;
};
#endif

} // namespace impeller