This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Improve Stencil Playground test#43641
Merged
Merged
Conversation
johnmccutchan
commented
Jul 13, 2023
johnmccutchan
commented
Contributor
- Add UI to select front and back face comparision functions.
- Fix back face.
bdero
approved these changes
Jul 13, 2023
- Add UI to select front and back face comparision functions. - Fix back face.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2023
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 13, 2023
flutter-team-archive/engine@081fbab...c31cfc5 2023-07-13 jonahwilliams@google.com [Impeller] Switch back to using explicit flush for device buffers. (flutter-team-archive/engine#43644) 2023-07-13 15619084+vashworth@users.noreply.github.com Add logs to debug VM Service Publication (flutter-team-archive/engine#43616) 2023-07-13 31859944+LongCatIsLooong@users.noreply.github.com Revert "Add a flag to `ParagraphBuilder` for rounding hack migration" (flutter-team-archive/engine#43642) 2023-07-13 47866232+chunhtai@users.noreply.github.com [web] TextField a11y focus should call didGain/didLose a11y focus action (flutter-team-archive/engine#43279) 2023-07-13 john@johnmccutchan.com Improve Stencil Playground test (flutter-team-archive/engine#43641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
- Add UI to select front and back face comparision functions. - Fix back face.
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
- Add UI to select front and back face comparision functions. - Fix back face.
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…0512) flutter-team-archive/engine@081fbab...c31cfc5 2023-07-13 jonahwilliams@google.com [Impeller] Switch back to using explicit flush for device buffers. (flutter-team-archive/engine#43644) 2023-07-13 15619084+vashworth@users.noreply.github.com Add logs to debug VM Service Publication (flutter-team-archive/engine#43616) 2023-07-13 31859944+LongCatIsLooong@users.noreply.github.com Revert "Add a flag to `ParagraphBuilder` for rounding hack migration" (flutter-team-archive/engine#43642) 2023-07-13 47866232+chunhtai@users.noreply.github.com [web] TextField a11y focus should call didGain/didLose a11y focus action (flutter-team-archive/engine#43279) 2023-07-13 john@johnmccutchan.com Improve Stencil Playground test (flutter-team-archive/engine#43641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.