Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Allow for optional label to trigger vuln scan on patch PRs #42494

Merged
auto-submit merged 2 commits into from
Jun 2, 2023
Merged

Allow for optional label to trigger vuln scan on patch PRs #42494

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7149522
use label in optional vuln scan run
sealesj Jun 1, 2023
ca3deb0
change name of label
sealesj Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/third_party_scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
branch_protection_rule:
push:
branches: [ main ]
pull_request:
types: [ labeled ]

# Declare default permissions as read only.
permissions: read-all
Expand All @@ -12,7 +14,8 @@ jobs:
vuln-scan:
name: Vulnerability scanning
runs-on: ubuntu-20.04
if: ${{ github.repository == 'flutter/engine' }}
# run on flutter/engine push to main or PRs with 'vulnerability patch' label
if: ${{ github.repository == 'flutter/engine' && (github.event_name == 'push' || github.event.label.name == 'vulnerability patch') }}

@zanderso zanderso Jun 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be called "vulnerability scan" instead? I'm worried that "vulnerability patch" will create confusion.

permissions:
# Needed to upload the SARIF results to code-scanning dashboard.
security-events: write
Expand Down