Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Simplify CreateContentsForGeometry overloads #42306

Merged
bdero merged 1 commit into from
May 25, 2023
+2 −12
Merged

[Impeller] Simplify CreateContentsForGeometry overloads #42306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions impeller/aiks/paint.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,12 @@ std::shared_ptr<Contents> Paint::CreateContentsForEntity(const Path& path,
}

std::shared_ptr<Contents> Paint::CreateContentsForGeometry(
std::unique_ptr<Geometry> geometry) const {
std::shared_ptr<Geometry> geometry) const {
auto contents = color_source.GetContents(*this);
contents->SetGeometry(std::move(geometry));
return contents;
}

std::shared_ptr<Contents> Paint::CreateContentsForGeometry(
const std::shared_ptr<Geometry>& geometry) const {
auto contents = color_source.GetContents(*this);
contents->SetGeometry(geometry);
return contents;
}

std::shared_ptr<Contents> Paint::WithFilters(
std::shared_ptr<Contents> input,
std::optional<bool> is_solid_color) const {
Expand Down
5 changes: 1 addition & 4 deletions impeller/aiks/paint.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,7 @@ struct Paint {
bool cover = false) const;

std::shared_ptr<Contents> CreateContentsForGeometry(
std::unique_ptr<Geometry> geometry) const;

std::shared_ptr<Contents> CreateContentsForGeometry(
const std::shared_ptr<Geometry>& geometry) const;
std::shared_ptr<Geometry> geometry) const;

/// @brief Whether this paint has a color filter that can apply opacity
bool HasColorFilter() const;
Expand Down