Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll buildroot to e522d38d629d7522f0589e754886ed2b82232d9e#42292

Closed
cbracken wants to merge 1 commit into
flutter-team-archive:mainfrom
cbracken:roll-buildroot-dynamic-fontconfig
Closed

Roll buildroot to e522d38d629d7522f0589e754886ed2b82232d9e#42292
cbracken wants to merge 1 commit into
flutter-team-archive:mainfrom
cbracken:roll-buildroot-dynamic-fontconfig

Conversation

@cbracken

Copy link
Copy Markdown
Contributor

Contains:

Migrates from a statically-linked fontconfig to dyanmically linked. This is likely to fix various fontconfig-related issues such as:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Contains:
* Dynamically link against system fontconfig (flutter-team-archive/buildroot#701)

Migrates from a statically-linked fontconfig to dyanmically linked. This
is likely to fix various fontconfig-related issues such as:
* flutter/flutter#118911
* Failures seen in #38144
@cbracken

Copy link
Copy Markdown
Contributor Author

Closing -- I originally opened this as a backup in case @vially wasn't around to update/land #40725 given how long it was pending, but that patch is good to go now. I've pushed the roll commit to that PR.

@cbracken cbracken closed this May 25, 2023
@cbracken cbracken deleted the roll-buildroot-dynamic-fontconfig branch May 25, 2023 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant