Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

CP: Reland "Move linux_license to engine v2."" (#41983)#42008

Merged
CaseyHillers merged 1 commit into
flutter-team-archive:flutter-3.11-candidate.0from
godofredoc:cp_2_5
May 15, 2023
Merged

CP: Reland "Move linux_license to engine v2."" (#41983)#42008
CaseyHillers merged 1 commit into
flutter-team-archive:flutter-3.11-candidate.0from
godofredoc:cp_2_5

Conversation

@godofredoc

@godofredoc godofredoc commented May 13, 2023

Copy link
Copy Markdown
Contributor

CP: b249781

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc requested a review from XilaiZhang May 13, 2023 03:53
@godofredoc godofredoc requested a review from itsjustkevin May 13, 2023 03:53
@godofredoc godofredoc mentioned this pull request May 13, 2023
Closed
XilaiZhang
XilaiZhang approved these changes May 13, 2023
View reviewed changes

@XilaiZhang XilaiZhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@CaseyHillers CaseyHillers merged commit e7e1cea into flutter-team-archive:flutter-3.11-candidate.0 May 15, 2023
@godofredoc godofredoc deleted the cp_2_5 branch June 2, 2023 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin
2 more reviewers
@XilaiZhang XilaiZhang XilaiZhang approved these changes
@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @XilaiZhang @fluttergithubbot @CaseyHillers