Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[tests] Remove unused fuchsia.sys protocol reference#41826

Merged
arbreng merged 2 commits into
flutter-team-archive:mainfrom
drwez:removeSysEnvironment
May 9, 2023
Merged

[tests] Remove unused fuchsia.sys protocol reference#41826
arbreng merged 2 commits into
flutter-team-archive:mainfrom
drwez:removeSysEnvironment

Conversation

@drwez

@drwez drwez commented May 8, 2023

Copy link
Copy Markdown
Contributor

Remove reference to unused fuchsia.sys.Environment protocol in test Realm setup. Besides being unused,
the reference was not correctly matched by an #include, nor a GN build dependency.

Bug: fxbug.dev/81285

@drwez

drwez commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

@arbreng PTAL - this should be the final remaining change (indirectly) required to allow the legacy CreateView() to be removed from Fuchsia.

@arbreng arbreng self-requested a review May 9, 2023 01:32
@arbreng arbreng merged commit a84b7aa into flutter-team-archive:main May 9, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request May 9, 2023
flutter-team-archive/engine@8d3a816...824cd09

2023-05-09 godofredoc@google.com Increase timeout of orchestrator. (flutter-team-archive/engine#41839)
2023-05-09 ianloic@google.com [fuchsia] Stop calling FIDL from Dart in Flutter integration tests (flutter-team-archive/engine#41669)
2023-05-09 wez@google.com [tests] Remove unused fuchsia.sys protocol reference (flutter-team-archive/engine#41826)
2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 7736fbaf84f0 to 485cd3d0f9ca (6 revisions) (flutter-team-archive/engine#41840)
2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] introduces DeviceHolder to avoid accessing a dead Device (flutter-team-archive/engine#41748)
2023-05-08 jacksongardner@google.com Get rid of "outrageous" default text styles for HTML renderer. (flutter-team-archive/engine#41822)
2023-05-08 flar@google.com Adjust DL filter bounds tests to not rely on exact Skia results (flutter-team-archive/engine#41792)
2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from a8b6687327d6 to 498cfa57165b (1 revision) (flutter-team-archive/engine#41823)
2023-05-08 JonathanPeterCole@gmail.com [Android] Fix incorrect viewInsets during keyboard animation with EdgeToEdge (flutter-team-archive/engine#39391)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 951eb9653163 to 7736fbaf84f0 (1 revision) (flutter-team-archive/engine#41821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants