This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] use callConstructor for FinalizationRegistry#40845
Closed
yjbanov wants to merge 1 commit into
Closed
Conversation
yjbanov
force-pushed
the
fix-finalization-registry-2
branch
from
April 1, 2023 16:30
4b0aa78 to
9d79ef7
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Contributor
Author
|
Closing this one as it builds on top of a reverted PR: #40861 I'll start a new one that contains both fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
js_util.callConstructorto initializeFinalizationRegistryto make it compatible withdart2js.Fixes b/276167870
This is the second attempt to land #40798. The previous attempt failed because in JS strings are not objects 🤷