Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Add ui_web to embedder.yaml so that the analyzer knows about it."#40840

Merged
zanderso merged 1 commit into
mainfrom
revert-40827-ui_web_analysis
Apr 1, 2023
Merged

Revert "Add ui_web to embedder.yaml so that the analyzer knows about it."#40840
zanderso merged 1 commit into
mainfrom
revert-40827-ui_web_analysis

Conversation

@zanderso

@zanderso zanderso commented Apr 1, 2023

Copy link
Copy Markdown
Contributor

Reverts #40827

This is causing the engine -> framework roll to fail in docs generation

@zanderso

zanderso commented Apr 1, 2023

Copy link
Copy Markdown
Contributor Author

Starting in flutter/flutter#123905

https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20docs_test/25897/overview

Executing: (cd dev/docs ; /b/s/w/ir/x/w/Á flutter sdk/bin/cache/dart-sdk/bin/dart global run dartdoc --allow-tools --no-validate-links --link-to-source-excludes ../../bin/cache --link-to-source-root ../.. --link-to-source-uri-template [https://github.com/flutter/flutter/blob/master/%f%#L%l](https://github.com/flutter/flutter/blob/master/%25f%25#L%25l)% --inject-html --use-base-href --header styles.html --header analytics.html --header survey.html --header snippets.html --header opensearch.html --footer-text lib/footer.html --allow-warnings-in-packages Flutter,platform_integration,flutter_localizations,flutter_goldens,flutter_driver,flutter,flutter_test,flutter_web_plugins,integration_test --exclude-packages analyzer,args,barback,csslib,flutter_goldens,flutter_goldens_client,front_end,fuchsia_remote_debug_protocol,glob,html,http_multi_server,io,isolate,js,kernel,logging,mime,mockito,node_preamble,plugin,shelf,shelf_packages_handler,shelf_static,shelf_web_socket,utf,watcher,yaml --exclude dart:io/network_policy.dart,package:Flutter/temp_doc.dart,package:http/browser_client.dart,package:intl/intl_browser.dart,package:matcher/mirror_matchers.dart,package:quiver/io.dart,package:quiver/mirrors.dart,package:vm_service_client/vm_service_client.dart,package:web_socket_channel/html.dart --favicon=favicon.ico --package-order flutter,Dart,platform_integration,flutter_test,flutter_driver --auto-include-dependencies)
dartdoc:stdout: Documenting Flutter...
dartdoc:stderr:
dartdoc:stderr: dartdoc 6.2.1 (/b/s/w/ir/x/w/.pub-cache/global_packages/dartdoc/bin/dartdoc.dart-3.0.0-387.0.dev.snapshot) failed: fatal error: unable to locate the input directory at /b/s/w/ir/x/w/Á flutter sdk/bin/cache/pkg/sky_engine/lib/ui_web..

@eyebrowsoffire eyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
zanderso merged commit c3c951c into main Apr 1, 2023
@zanderso
zanderso deleted the revert-40827-ui_web_analysis branch April 1, 2023 00:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Apr 1, 2023
…23924)

Manual roll requested by zra@google.com

flutter-team-archive/engine@b2855e0...a48eedb

2023-04-01 zanderso@users.noreply.github.com Revert "[web] Move text
editing nodes outside of shadowDOM" (flutter-team-archive/engine#40847)
2023-04-01 skia-flutter-autoroll@skia.org Roll Skia from 4d1e9cabf0c8 to
9973ef180f1f (2 revisions) (flutter-team-archive/engine#40843)
2023-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from
6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter-team-archive/engine#40842)
2023-04-01 jonahwilliams@google.com [Impeller] take advantage of native
decal sampling, blend cleanups (flutter-team-archive/engine#40839)
2023-04-01 yjbanov@google.com Revert "[web] use callConstructor for
FinalizationRegistry due to bug… (flutter-team-archive/engine#40841)
2023-04-01 zanderso@users.noreply.github.com Revert "Add ui_web to
embedder.yaml so that the analyzer knows about it."
(flutter-team-archive/engine#40840)
2023-04-01 jonahwilliams@google.com [Impeller] Migrate gaussian blur to
half precision. (flutter-team-archive/engine#40800)
2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 33f80c07a09c to
4d1e9cabf0c8 (3 revisions) (flutter-team-archive/engine#40836)
2023-03-31 110993981+htoor3@users.noreply.github.com [web] Move text
editing nodes outside of shadowDOM (flutter-team-archive/engine#39688)
2023-03-31 mdebbar@google.com [web] Fix canvasKitVariant test
(flutter-team-archive/engine#40833)
2023-03-31 yjbanov@google.com [web] use callConstructor for
FinalizationRegistry due to bug in dart2js (flutter-team-archive/engine#40798)
2023-03-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter-team-archive/engine#40831)
2023-03-31 godofredoc@google.com Remove ios-release-nobitcode from
engine v2 builders. (flutter-team-archive/engine#40830)
2023-03-31 jacksongardner@google.com Add ui_web to embedder.yaml so that
the analyzer knows about it. (flutter-team-archive/engine#40827)
2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 2b86c6d364d0 to
33f80c07a09c (1 revision) (flutter-team-archive/engine#40826)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
…utter#123924)

Manual roll requested by zra@google.com

flutter-team-archive/engine@b2855e0...a48eedb

2023-04-01 zanderso@users.noreply.github.com Revert "[web] Move text
editing nodes outside of shadowDOM" (flutter-team-archive/engine#40847)
2023-04-01 skia-flutter-autoroll@skia.org Roll Skia from 4d1e9cabf0c8 to
9973ef180f1f (2 revisions) (flutter-team-archive/engine#40843)
2023-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from
6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter-team-archive/engine#40842)
2023-04-01 jonahwilliams@google.com [Impeller] take advantage of native
decal sampling, blend cleanups (flutter-team-archive/engine#40839)
2023-04-01 yjbanov@google.com Revert "[web] use callConstructor for
FinalizationRegistry due to bug… (flutter-team-archive/engine#40841)
2023-04-01 zanderso@users.noreply.github.com Revert "Add ui_web to
embedder.yaml so that the analyzer knows about it."
(flutter-team-archive/engine#40840)
2023-04-01 jonahwilliams@google.com [Impeller] Migrate gaussian blur to
half precision. (flutter-team-archive/engine#40800)
2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 33f80c07a09c to
4d1e9cabf0c8 (3 revisions) (flutter-team-archive/engine#40836)
2023-03-31 110993981+htoor3@users.noreply.github.com [web] Move text
editing nodes outside of shadowDOM (flutter-team-archive/engine#39688)
2023-03-31 mdebbar@google.com [web] Fix canvasKitVariant test
(flutter-team-archive/engine#40833)
2023-03-31 yjbanov@google.com [web] use callConstructor for
FinalizationRegistry due to bug in dart2js (flutter-team-archive/engine#40798)
2023-03-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter-team-archive/engine#40831)
2023-03-31 godofredoc@google.com Remove ios-release-nobitcode from
engine v2 builders. (flutter-team-archive/engine#40830)
2023-03-31 jacksongardner@google.com Add ui_web to embedder.yaml so that
the analyzer knows about it. (flutter-team-archive/engine#40827)
2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 2b86c6d364d0 to
33f80c07a09c (1 revision) (flutter-team-archive/engine#40826)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants