This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] support half precision uniforms and half precision samplers"#40766
Closed
CaseyHillers wants to merge 1 commit into
Closed
Revert "[Impeller] support half precision uniforms and half precision samplers"#40766CaseyHillers wants to merge 1 commit into
CaseyHillers wants to merge 1 commit into
Conversation
XilaiZhang
approved these changes
Mar 29, 2023
XilaiZhang
left a comment
XilaiZhang
left a comment
Contributor
There was a problem hiding this comment.
Umm it seems like a number of tests are failing with right paren error which i am not quite familiar with
Contributor
Author
|
FYI, I'm feeling under the weather, and have handed this off to @XilaiZhang to continue. |
Contributor
|
Closing this as the revert cannot land as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #40590
See b/275717711. This change is not currently compatible with the version of llvm used in Google Testing.
Starting a revert to kick the presubmits while we continue to investigate.