This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use analyzer from dart source everywhere#40398
Merged
auto-submit[bot] merged 1 commit intoMar 17, 2023
Merged
Conversation
flutter-dashboard
Bot
added
the
platform-web
Contributor
Author
|
@mdebbar Can you take another look at this? Sorry with the churn on this one, but I think this approach will lessen future pain when it comes to upgrading to new dart versions. |
mdebbar
approved these changes
Mar 17, 2023
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 18, 2023
* e6334f1 [web] Remove image codecs from Canvaskit Chromium (flutter-team-archive/engine#40309) * 56727d6 Revert "[Impeller] mark decoded images as optimized for GPU access (#40356)" (flutter-team-archive/engine#40387) * 2cd19e3 Wrap the iOS platform message handler in an autorelease pool block (flutter-team-archive/engine#40373) * bab7853 Update analyzer for api_conform_test (flutter-team-archive/engine#40386) * 87b2e82 Roll Fuchsia Mac SDK from z32cF6YFs6CvZbY3g... to 4ZrEK2uzGdp_Gz3DU... (flutter-team-archive/engine#40385) * fc57995 Ignore some MTLCompiler failures in impeller unit tests (flutter-team-archive/engine#40391) * 2398c52 Add doc comment to Pipeline (flutter-team-archive/engine#40388) * f585d4b [macOS] Remove a single accessibility root assumption (flutter-team-archive/engine#40316) * 940cf3c remove temporary flag and make FlutterTest the default font for real (flutter-team-archive/engine#40352) * a1bf9fd drawTextBlob should not be compatible with opacity inheritance (flutter-team-archive/engine#40396) * 55bf0d8 Use bundled analyzer everywhere (flutter-team-archive/engine#40398) * 8e58041 Roll Skia from 9bfb45d3e065 to 49b902e5fb91 (11 revisions) (flutter-team-archive/engine#40397) * 77c53d2 Default the CanvasKit base URL to local artifacts. (flutter-team-archive/engine#40293) * 625ea53 Roll Skia from 49b902e5fb91 to aa983f5486f0 (7 revisions) (flutter-team-archive/engine#40404) * 867679f [Impeller] Add playground flag to render for a specific amount of time. (flutter-team-archive/engine#40377) * d741696 [Impeller] Remove unused bounds method from typographer interface (flutter-team-archive/engine#40406) * 941323d Provisional iOS impeller flag flip (flutter-team-archive/engine#40405) * bb971ab Revert "Default the CanvasKit base URL to local artifacts. (#40293)" (flutter-team-archive/engine#40415)
zanderso
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #40328 it tripped me up that the analyzer used by
tools/api_checkbehaved differently than the analyzer used byweb_sdk. The reason for that mystery was:tools/api_checkuses the analyzer directly from the dart sources, whileweb_sdkused an (outdated) version from pub. The version from pub will always be slightly behind, which is whyweb_sdksometimes requires fiddling with experiment flags to get it to behave as expected (see #40386). That's annoying and having to deal with different analyzer versions is confusing. This change migratesweb_sdkto always use the up-to-date analyzer from the dart sources directly, just liketools/api_checkdoes:https://github.com/flutter/engine/blob/fc57995fe137d883016a6c115bf45710883cd77c/tools/api_check/pubspec.yaml#L40-L82