Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[macOS,Windows] Use static casts where possible#40334

Merged
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
cbracken:fix-unnecessary-reinterpret
Mar 16, 2023
Merged

[macOS,Windows] Use static casts where possible#40334
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
cbracken:fix-unnecessary-reinterpret

Conversation

@cbracken

Copy link
Copy Markdown
Contributor

Fixes a few instances where we were using reinterpret_cast and reinterpret_pointer_cast but could have been using static_cast since the types being cast between are related types in the same hierarchy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Fixes a few instances where we were using reinterpret_cast and
reinterpret_pointer_cast but could have been using static_cast since the
types being cast between are related types in the same hierarchy.

@dkwingsmt dkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as long as the compiler agrees, right?

@cbracken

cbracken commented Mar 16, 2023

Copy link
Copy Markdown
Contributor Author

Yeah the various casts are compile-time features (except dynamic_cast which requires RTTI enabled). The real question is whether Windows is happy with this; the patch was written on a Mac, so I haven't tested on my Windows machine, but CI will tell us.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit auto-submit Bot merged commit c4eb291 into flutter-team-archive:main Mar 16, 2023
@cbracken cbracken deleted the fix-unnecessary-reinterpret branch March 16, 2023 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-macos platform-windows

Development

Successfully merging this pull request may close these issues.

2 participants