Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2081,6 +2081,14 @@ - (void)removeEnableFlutterTextInputViewAccessibilityTimer {
}

- (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
if (_viewController.view == nil) {
Comment thread
luckysmg marked this conversation as resolved.
Outdated
// If UIViewController's view has been detached, we ignore incoming method call
// to avoid crash.
// See https://github.com/flutter/flutter/issues/106404.
result(nil);
return;
}

NSString* method = call.method;
id args = call.arguments;
if ([method isEqualToString:kShowMethod]) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,24 @@ - (FlutterTextRange*)getLineRangeFromTokenizer:(id<UITextInputTokenizer>)tokeniz

#pragma mark - Tests

- (void)testTextInputPluginWillNotHandleMethodWhenViewControllerIsNil {
FlutterEngine* flutterEngine = [[FlutterEngine alloc] init];
FlutterTextInputPlugin* inputPlugin =
[[FlutterTextInputPlugin alloc] initWithDelegate:(id<FlutterTextInputDelegate>)flutterEngine];
XCTAssertNil(inputPlugin.viewController);
FlutterMethodCall* methodCall = [FlutterMethodCall methodCallWithMethodName:@"TextInput.show"
arguments:nil];
XCTestExpectation* expectation = [[XCTestExpectation alloc] initWithDescription:@"result called"];

[inputPlugin handleMethodCall:methodCall
result:^(id _Nullable result) {
XCTAssertNil(result);
[expectation fulfill];
}];
XCTAssertNil(inputPlugin.activeView);
[self waitForExpectations:@[ expectation ] timeout:1.0];
}

- (void)testInvokeStartLiveTextInput {
FlutterMethodCall* methodCall =
[FlutterMethodCall methodCallWithMethodName:@"TextInput.startLiveTextInput" arguments:nil];
Expand Down