Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only - #39112

Merged
bdero merged 1 commit into
flutter-team-archive:mainfrom
bdero:bdero/text-sampling-translation-only
Jan 25, 2023
Merged

[Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only#39112
bdero merged 1 commit into
flutter-team-archive:mainfrom
bdero:bdero/text-sampling-translation-only

Conversation

@bdero

@bdero bdero commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

Follow-up to #39104.

Before:
image

After:
image

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdero
bdero merged commit 55bb8de into flutter-team-archive:main Jan 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 25, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 25, 2023
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Jan 25, 2023
… isn't translation/scale only (flutter-team-archive/engine#39112) (#119098)

Commit: 426cdd90cdf32bc82f21c7ea384d7f2813b9f5e0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 25, 2023
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jan 25, 2023
* 3735231 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819)

* 4d25030 Add leak_tracker as dev_dependency.  (flutter/flutter#118952)

* e3c51a2 Add Windows unit tests to plugin template (flutter/flutter#118638)

* d20dd9e Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081)

* 5dabe10 Fix path name to discover debug apk on add2app builds (flutter/flutter#117999)

* 50ed8a3 Enable `unnecessary_null_comparison` check (flutter/flutter#118849)

* 455e6ac Test integration test apps' runner files against current template app (flutter/flutter#118646)

* a788e1b Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087)

* c35370c Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089)

* 2f0dd56 Refactor highlight handling in FocusManager (flutter/flutter#119075)

* 2759f3f Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090)

* 760fb21 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093)

* bbca694 Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095)

* 6414c36 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter-team-archive/engine#38650) (flutter/flutter#119097)

* 426cdd9 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter-team-archive/engine#39112) (flutter/flutter#119098)

* 83c3a61 Only emit image painting events in debug & profile modes. (flutter/flutter#118872)

* b113df2 bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter-team-archive/engine#39114) (flutter/flutter#119099)

* 351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454)

* 318f875 Pass through magnifierConfiguration (flutter/flutter#118270)

* eced23e d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter-team-archive/engine#39122) (flutter/flutter#119126)

* 29ab437 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792)

* a815ee6 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter-team-archive/engine#39123) (flutter/flutter#119129)
ricardoamador pushed a commit to ricardoamador/engine that referenced this pull request Jan 25, 2023
auto-submit Bot pushed a commit to flutter-team-archive/plugins that referenced this pull request Jan 25, 2023
* 3735231 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819)

* 4d25030 Add leak_tracker as dev_dependency.  (flutter/flutter#118952)

* e3c51a2 Add Windows unit tests to plugin template (flutter/flutter#118638)

* d20dd9e Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081)

* 5dabe10 Fix path name to discover debug apk on add2app builds (flutter/flutter#117999)

* 50ed8a3 Enable `unnecessary_null_comparison` check (flutter/flutter#118849)

* 455e6ac Test integration test apps' runner files against current template app (flutter/flutter#118646)

* a788e1b Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087)

* c35370c Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089)

* 2f0dd56 Refactor highlight handling in FocusManager (flutter/flutter#119075)

* 2759f3f Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090)

* 760fb21 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093)

* bbca694 Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095)

* 6414c36 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter-team-archive/engine#38650) (flutter/flutter#119097)

* 426cdd9 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter-team-archive/engine#39112) (flutter/flutter#119098)

* 83c3a61 Only emit image painting events in debug & profile modes. (flutter/flutter#118872)

* b113df2 bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter-team-archive/engine#39114) (flutter/flutter#119099)

* 351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454)

* 318f875 Pass through magnifierConfiguration (flutter/flutter#118270)

* eced23e d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter-team-archive/engine#39122) (flutter/flutter#119126)

* 29ab437 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792)

* a815ee6 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter-team-archive/engine#39123) (flutter/flutter#119129)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
…hive#7025)

* 3735231 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819)

* 4d25030 Add leak_tracker as dev_dependency.  (flutter/flutter#118952)

* e3c51a2 Add Windows unit tests to plugin template (flutter/flutter#118638)

* d20dd9e Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081)

* 5dabe10 Fix path name to discover debug apk on add2app builds (flutter/flutter#117999)

* 50ed8a3 Enable `unnecessary_null_comparison` check (flutter/flutter#118849)

* 455e6ac Test integration test apps' runner files against current template app (flutter/flutter#118646)

* a788e1b Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087)

* c35370c Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089)

* 2f0dd56 Refactor highlight handling in FocusManager (flutter/flutter#119075)

* 2759f3f Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090)

* 760fb21 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093)

* bbca694 Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095)

* 6414c36 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter-team-archive/engine#38650) (flutter/flutter#119097)

* 426cdd9 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter-team-archive/engine#39112) (flutter/flutter#119098)

* 83c3a61 Only emit image painting events in debug & profile modes. (flutter/flutter#118872)

* b113df2 bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter-team-archive/engine#39114) (flutter/flutter#119099)

* 351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454)

* 318f875 Pass through magnifierConfiguration (flutter/flutter#118270)

* eced23e d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter-team-archive/engine#39122) (flutter/flutter#119126)

* 29ab437 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792)

* a815ee6 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter-team-archive/engine#39123) (flutter/flutter#119129)
zanderso pushed a commit to zanderso/engine that referenced this pull request Jan 26, 2023
XilaiZhang pushed a commit that referenced this pull request Jan 31, 2023
* [Impeller] Switch to nearest sampling for the text atlas (#39104)

* [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (#39112)

---------

Co-authored-by: Brandon DeRosier <bdero@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants