This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Re-enable UIA text/range provider unit tests - #38718
Merged
yaakovschectman merged 2 commits intoJan 9, 2023
Merged
Conversation
yaakovschectman
requested review from
a-wallen,
cbracken,
chunhtai,
dkwingsmt and
loic-sharma
January 9, 2023 15:09
a-wallen
approved these changes
Jan 9, 2023
loic-sharma
reviewed
Jan 9, 2023
| } | ||
|
|
||
| } // namespace ui | ||
| } // namespace ui No newline at end of file |
Contributor
There was a problem hiding this comment.
I believe the style guide requires that files end with an empty line.
See this as for why: https://stackoverflow.com/questions/2287967/why-is-it-recommended-to-have-empty-line-in-the-end-of-a-source-file
loic-sharma
approved these changes
Jan 9, 2023
This was referenced Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring back up the previously disabled unit tests for TextProvider and TextRangeProvider now that they are implemented
Part of flutter/flutter#116219 and #117012
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.