Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make operator == parameter non-nullable - #38663

Merged
srawlins merged 2 commits into
flutter-team-archive:mainfrom
srawlins:nullable-equal-equal
Jan 10, 2023
Merged

Make operator == parameter non-nullable#38663
srawlins merged 2 commits into
flutter-team-archive:mainfrom
srawlins:nullable-equal-equal

Conversation

@srawlins

@srawlins srawlins commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Make operator == override parameters no-nullable.

Fixes flutter/flutter#117838

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the platform-web Code specifically for the web engine label Jan 5, 2023
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@srawlins

Copy link
Copy Markdown
Contributor Author

Ready to roll

@srawlins
srawlins merged commit 95c7b1f into flutter-team-archive:main Jan 10, 2023
@srawlins
srawlins deleted the nullable-equal-equal branch January 10, 2023 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-web Code specifically for the web engine

Development

Successfully merging this pull request may close these issues.

Some classes override operator == with a nullable parameter

2 participants