Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[impellerc] Set file access mode of .iplr output to 0644 (#35186)#35269

Merged
itsjustkevin merged 1 commit into
flutter-team-archive:flutter-3.2-candidate.5from
zanderso:impellerc-3.3-cp
Aug 9, 2022
Merged

[impellerc] Set file access mode of .iplr output to 0644 (#35186)#35269
itsjustkevin merged 1 commit into
flutter-team-archive:flutter-3.2-candidate.5from
zanderso:impellerc-3.3-cp

Conversation

@zanderso

@zanderso zanderso commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

@flutter-dashboard
flutter-dashboard Bot changed the base branch from flutter-3.2-candidate.5 to main August 9, 2022 15:50
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot added platform-android platform-web Code specifically for the web engine labels Aug 9, 2022
@zanderso
zanderso changed the base branch from main to flutter-3.2-candidate.5 August 9, 2022 15:50
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin
itsjustkevin merged commit f16e757 into flutter-team-archive:flutter-3.2-candidate.5 Aug 9, 2022
@zanderso
zanderso deleted the impellerc-3.3-cp branch August 10, 2022 01:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-android platform-web Code specifically for the web engine

Development

Successfully merging this pull request may close these issues.

3 participants