Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Fix GDI resource leaks in the software fallback path#34574

Merged
loic-sharma merged 1 commit into
flutter-team-archive:mainfrom
sevenstars:fix_dc_leak
Jul 15, 2022
Merged

[Windows] Fix GDI resource leaks in the software fallback path#34574
loic-sharma merged 1 commit into
flutter-team-archive:mainfrom
sevenstars:fix_dc_leak

Conversation

@sevenstars

@sevenstars sevenstars commented Jul 10, 2022

Copy link
Copy Markdown
Contributor

In FlutterWindowWin32::OnBitmapSurfaceUpdated(), the ReleaseDC function is not called to release the DC.
The ReleaseDC function must be called to release the DC.

This PR will fix issue: flutter/flutter#107368

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@sevenstars sevenstars mentioned this pull request Jul 12, 2022
Closed
@loic-sharma

loic-sharma commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

LGTM. I tested before/after this change using this repro flutter/flutter#107368 (comment).

@gw280 do you have concerns with this?

@loic-sharma loic-sharma merged commit c29bf8f into flutter-team-archive:main Jul 15, 2022
@loic-sharma

loic-sharma commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Thanks for the contribution! 🎉

betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 15, 2022
@betrevisan
[Windows] Fix GDI resource leaks in the software fallback path (flutt…
58471bd 
…er-team-archive#34574)

Updates `FlutterWindowWin32::OnBitmapSurfaceUpdated` to release the device context using `ReleaseDC`.

Fixes: flutter/flutter#107368
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
c29bf8f [Windows] Fix GDI resource leaks in the software fallback path (
1e24c45 
flutter-team-archive/engine#34574)
zanderso pushed a commit to flutter/flutter that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
c29bf8f [Windows] Fix GDI resource leaks in the software fallback path (
5c33db6 
flutter-team-archive/engine#34574) (#107754)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Jul 16, 2022
flutter: c29bf8fcf [Windows] Fix GDI resource leaks in the software f…
8ff46d6 
…allback path (flutter-team-archive/engine#34574) (#107754)

Commit: 5c33db6ccd46f29512e5a06c73aa6caf18779c23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
a537d9c 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
e170e14 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
f2e0198 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
3febe81 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
3cef357 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
a2b5ab1 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
a0bce03 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
4aa1431 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
fdbadb5 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
721f2aa 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
30d90d2 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
3ee62ce 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
9e9f4c0 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
26ac99c 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
4868ae9 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
2c50b8a 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
d425274 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
ab948ef 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
7a9f433 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
fd1d034 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
19d2368 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
7dc9f3e 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
f26d2e1 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
b0532f0 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
19892ef 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
3fc8679 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
28fa8c9 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
100d10e 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
1a7e21a 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
91dd45f 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
f0f403e 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
9a357d0 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
b34f0fb 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
5c33db6 c29bf8fcf [Windows] Fix GDI resource leaks in the software fa…
f8ad6eb 
…llback path (flutter-team-archive/engine#34574) (flutter/flutter#107754)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll @camsim99
c29bf8f [Windows] Fix GDI resource leaks in the software fallback path (
d0326b7 
flutter-team-archive/engine#34574) (flutter#107754)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken Awaiting requested review from cbracken
2 more reviewers
@chinmaygarde chinmaygarde chinmaygarde approved these changes
@loic-sharma loic-sharma loic-sharma approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-windows

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sevenstars @loic-sharma @chinmaygarde