Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Disable several tests due to flakiness #32059

Merged
fluttergithubbot merged 2 commits into from
Mar 17, 2022
Merged

Disable several tests due to flakiness #32059

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e3ca86
Disable several tests due to flakiness
ColdPaleLight Mar 16, 2022
bb69362
update linked issue
ColdPaleLight Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions shell/common/shell_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,12 +1277,14 @@ TEST_F(ShellTest,
DestroyShell(std::move(shell));
}

// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to

@iskakaushik iskakaushik Mar 16, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please file a new issue to re-enable these tests and link it here? That way we still have an open issue to re-enable the tests. Thanks.

@ColdPaleLight ColdPaleLight Mar 17, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

// flakiness.
// TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia.
TEST_F(ShellTest,
#if defined(OS_FUCHSIA)
DISABLED_ResubmitFrame
#else
ResubmitFrame
DISABLED_ResubmitFrame
#endif
) {
auto settings = CreateSettingsForFixture();
Expand Down Expand Up @@ -2392,7 +2394,9 @@ TEST_F(ShellTest, OnServiceProtocolEstimateRasterCacheMemoryWorks) {
DestroyShell(std::move(shell));
}

TEST_F(ShellTest, DiscardLayerTreeOnResize) {
// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to
// flakiness.
TEST_F(ShellTest, DISABLED_DiscardLayerTreeOnResize) {
auto settings = CreateSettingsForFixture();

SkISize wrong_size = SkISize::Make(400, 100);
Expand Down Expand Up @@ -2442,7 +2446,9 @@ TEST_F(ShellTest, DiscardLayerTreeOnResize) {
DestroyShell(std::move(shell));
}

TEST_F(ShellTest, DiscardResubmittedLayerTreeOnResize) {
// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to
// flakiness.
TEST_F(ShellTest, DISABLED_DiscardResubmittedLayerTreeOnResize) {
auto settings = CreateSettingsForFixture();

SkISize origin_size = SkISize::Make(400, 100);
Expand Down