This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adds scripts for cross-arch macOS framework#31014
Merged
zanderso merged 1 commit intoJan 24, 2022
Merged
Conversation
jmagman
approved these changes
Jan 24, 2022
jmagman
reviewed
Jan 24, 2022
10 tasks
Contributor
|
x-ref Part of flutter/flutter#69221 |
zanderso
force-pushed
the
lipo-macos-framework
branch
from
478b810 to
c140746
Compare
zanderso
commented
Jan 24, 2022
cbracken
reviewed
Jan 24, 2022
cbracken
left a comment
cbracken
left a comment
Contributor
There was a problem hiding this comment.
Post-submit lgtm -- I'm just that excited about this :P
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds scripts to allow implementing an analogue of
PackageIOSVariant(here: https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine.py#1202) for macOS.I have verified that after the tool change here flutter/flutter#97111, apps targeting x64 still work with a framework packaged with this script.