This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix TaskRunnerTest.MaybeExecuteTaskOnlyExpired flake#29484
Merged
Conversation
Contributor
bdero
force-pushed
the
bdero/fix-92928
branch
from
November 2, 2021 20:14
629c57d to
d4ee67f
Compare
Contributor
Author
|
Since a function ptr for sampling the time is passed to the task runner, I went ahead and removed the time sampling to make it fully deterministic. |
cbracken
approved these changes
Nov 2, 2021
Contributor
|
Thanks @bdero! The |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 3, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#92928.
This test was scheduling a task only 0.01ms into the future and verifying that it doesn't get executed (which may happen by the time
runner.SimulateTimerAwake()samples the current time/depending on how precise it is).