Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

made android unit tests not require the host engine variant to exist #28925

Merged
gaaclarke merged 2 commits into from
Sep 29, 2021
Merged

made android unit tests not require the host engine variant to exist #28925

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11d2d5c
made android unit tests not require the host engine variant to exist
gaaclarke Sep 28, 2021
fcbc3d3
tweaked help page
gaaclarke Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions testing/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ def main():
help='A single Java test class to run.')
parser.add_argument('--android-variant', dest='android_variant', action='store',
default='android_debug_unopt',
help='The engine build variant to run java tests for')
help='The engine build variant to run java/android tests for')

@blasten blasten Sep 29, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "java or android". I thought / was a path separator

@gaaclarke gaaclarke Sep 29, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

parser.add_argument('--ios-variant', dest='ios_variant', action='store',
default='ios_debug_sim_unopt',
help='The engine build variant to run objective-c tests for')
Expand All @@ -561,7 +561,7 @@ def main():
types = args.type.split(',')

build_dir = os.path.join(out_dir, args.variant)
if args.type != 'java':
if args.type != 'java' and args.type != 'android':
assert os.path.exists(build_dir), 'Build variant directory %s does not exist!' % build_dir

if args.sanitizer_suppressions:
Expand Down