Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix dead key handling on Win32 (again)#28125

Merged
dkwingsmt merged 3 commits into
flutter-team-archive:masterfrom
dkwingsmt:fix-dead-char-again
Aug 17, 2021
Merged

Fix dead key handling on Win32 (again)#28125
dkwingsmt merged 3 commits into
flutter-team-archive:masterfrom
dkwingsmt:fix-dead-char-again

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

This PR tries to fix dead key handling on Win32:

  • Fix dead character crashes the channel handler.
  • Fix dead key messages are redispatched, making the message a regular character message.

It fixes the problem raised in #28047 (comment).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dkwingsmt dkwingsmt requested a review from gspencergoog August 17, 2021 11:00

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@knopp

knopp commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

@dkwingsmt, thank you for this! There is one issue that I noticed. Normal behavior in windows, when pressing the dead key twice is that it gets printed twice. I.e. ´´, with no dead key state afterwards. However pressing the dead key twice in Flutter prints the first dead key while the second dead key becomes active.

@dkwingsmt

Copy link
Copy Markdown
Contributor Author

@knopp That's interesting to know! I'll take a look afterwards. Thank you.

@dkwingsmt dkwingsmt merged commit 2eb5e42 into flutter-team-archive:master Aug 17, 2021
@dkwingsmt dkwingsmt deleted the fix-dead-char-again branch August 17, 2021 21:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
- Fix dead character crashes the channel handler.
- Fix dead key messages are redispatched, making the message a regular character message.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants