This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Configure LayerTree with a framework provided frame key#25662
Closed
jonahwilliams wants to merge 3 commits into
Closed
Configure LayerTree with a framework provided frame key#25662jonahwilliams wants to merge 3 commits into
jonahwilliams wants to merge 3 commits into
Conversation
flutter-dashboard
Bot
added
the
platform-web
iskakaushik
added a commit
that referenced
this pull request
May 3, 2021
`FlutterFrameTimingsRecorder` is passed through the lifecycle of the frame and records the events that happen through it. This also serves as a builder for the `FrameTiming` object that is later passed to the framework. This change also aims to lay the foundation to capture a unique frame identifier which will later be added to `FlutterFrameTimingsRecorder` to identify the trace events corresponding to each frame. x-ref: #25662 x-ref: flutter/flutter#80735
iskakaushik
added a commit
to iskakaushik/engine
that referenced
this pull request
May 3, 2021
`FlutterFrameTimingsRecorder` is passed through the lifecycle of the frame and records the events that happen through it. This also serves as a builder for the `FrameTiming` object that is later passed to the framework. This change also aims to lay the foundation to capture a unique frame identifier which will later be added to `FlutterFrameTimingsRecorder` to identify the trace events corresponding to each frame. x-ref: flutter-team-archive#25662 x-ref: flutter/flutter#80735
iskakaushik
added a commit
to iskakaushik/engine
that referenced
this pull request
May 3, 2021
`FlutterFrameTimingsRecorder` is passed through the lifecycle of the frame and records the events that happen through it. This also serves as a builder for the `FrameTiming` object that is later passed to the framework. This change also aims to lay the foundation to capture a unique frame identifier which will later be added to `FlutterFrameTimingsRecorder` to identify the trace events corresponding to each frame. x-ref: flutter-team-archive#25662 x-ref: flutter/flutter#80735
iskakaushik
added a commit
to iskakaushik/engine
that referenced
this pull request
May 3, 2021
`FlutterFrameTimingsRecorder` is passed through the lifecycle of the frame and records the events that happen through it. This also serves as a builder for the `FrameTiming` object that is later passed to the framework. This change also aims to lay the foundation to capture a unique frame identifier which will later be added to `FlutterFrameTimingsRecorder` to identify the trace events corresponding to each frame. x-ref: flutter-team-archive#25662 x-ref: flutter/flutter#80735
iskakaushik
added a commit
to iskakaushik/engine
that referenced
this pull request
May 3, 2021
`FlutterFrameTimingsRecorder` is passed through the lifecycle of the frame and records the events that happen through it. This also serves as a builder for the `FrameTiming` object that is later passed to the framework. This change also aims to lay the foundation to capture a unique frame identifier which will later be added to `FlutterFrameTimingsRecorder` to identify the trace events corresponding to each frame. x-ref: flutter-team-archive#25662 x-ref: flutter/flutter#80735
iskakaushik
added a commit
to iskakaushik/engine
that referenced
this pull request
May 3, 2021
`FlutterFrameTimingsRecorder` is passed through the lifecycle of the frame and records the events that happen through it. This also serves as a builder for the `FrameTiming` object that is later passed to the framework. This change also aims to lay the foundation to capture a unique frame identifier which will later be added to `FlutterFrameTimingsRecorder` to identify the trace events corresponding to each frame. x-ref: flutter-team-archive#25662 x-ref: flutter/flutter#80735
iskakaushik
added a commit
to iskakaushik/engine
that referenced
this pull request
May 7, 2021
`FlutterFrameTimingsRecorder` is passed through the lifecycle of the frame and records the events that happen through it. This also serves as a builder for the `FrameTiming` object that is later passed to the framework. This change also aims to lay the foundation to capture a unique frame identifier which will later be added to `FlutterFrameTimingsRecorder` to identify the trace events corresponding to each frame. x-ref: flutter-team-archive#25662 x-ref: flutter/flutter#80735
Contributor
Author
|
We're handling this differently in the engine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#80735
Framework PR: flutter/flutter#80760
WIP due to lack of testing