This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Enables semantics when voice control is turned on #24640
Merged
fluttergithubbot
merged 7 commits into
flutter-team-archive:master
from
chunhtai:issues/75887
Mar 4, 2021
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7cfa1ca
Enables semantics when voice control is turned on
chunhtai 269576c
fix license
chunhtai c5b17af
update
chunhtai 6c41137
typo
chunhtai 34f3436
update
chunhtai 9afca0a
fix typo
chunhtai 81c07b0
fix tests
chunhtai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
shell/platform/darwin/ios/framework/Source/FlutterViewTest.mm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #import <XCTest/XCTest.h> | ||
|
|
||
| #import "flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine_Internal.h" | ||
| #import "flutter/shell/platform/darwin/ios/framework/Source/FlutterView.h" | ||
|
|
||
| @interface FakeDelegate : FlutterEngine | ||
| @property(nonatomic) BOOL ensureSemanticsEnabledCalled; | ||
| @end | ||
|
|
||
| @implementation FakeDelegate | ||
|
|
||
| - (void)ensureSemanticsEnabled { | ||
| _ensureSemanticsEnabledCalled = YES; | ||
| } | ||
|
|
||
| @end | ||
|
|
||
| @interface FlutterViewTest : XCTestCase | ||
| @end | ||
|
|
||
| @implementation FlutterViewTest | ||
|
|
||
| - (void)testFlutterViewEnableSemanticsWhenIsAccessibilityElementIsCalled { | ||
| FakeDelegate* delegate = [[FakeDelegate alloc] initWithName:@"foobar"]; | ||
| FlutterView* view = [[FlutterView alloc] initWithDelegate:delegate opaque:NO]; | ||
| delegate.ensureSemanticsEnabledCalled = NO; | ||
| XCTAssertFalse(view.isAccessibilityElement); | ||
| XCTAssertTrue(delegate.ensureSemanticsEnabledCalled); | ||
| } | ||
|
|
||
| @end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method has to be updated, this test should be failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I inherited from the FlutterEngine so I only need to override ensureSemanticsEnabled. I want to test the FlutterView.isAccessibilityElement call eventually lead to ensureSemanticsEnabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otheriwse, I will need to write two tests.
one for FlutterView.isAccessibilityElement calls FlutterViewEngineDelegate.flutterViewAccessibilityDidCall
the other one for FlutterEngine.flutterViewAccessibilityDidCall calls FlutterEngine.ensureSemanticsEnabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yea, sorry missed that. I think you should use a mock object to keep the test hermetic. Now you're tying your testing of functionality on FlutterView to implementation details in FlutterEngine which is fragile. It easy to replace it if you use OCMock, there are examples in other tests.