Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fixed plumbing of the spawning isolate for Shell::Spawn.#24112

Merged
gaaclarke merged 1 commit into
flutter-team-archive:masterfrom
gaaclarke:fix-missing-spawning-engine
Feb 1, 2021
Merged

Fixed plumbing of the spawning isolate for Shell::Spawn.#24112
gaaclarke merged 1 commit into
flutter-team-archive:masterfrom
gaaclarke:fix-missing-spawning-engine

Conversation

@gaaclarke

Copy link
Copy Markdown
Contributor

issue: flutter/flutter#72025

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@xster xster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke

Copy link
Copy Markdown
Contributor Author

Ugh, that took way to long to verify on a real device. Looks good on device, too.

@gaaclarke
gaaclarke marked this pull request as ready for review February 1, 2021 23:32
@gaaclarke
gaaclarke merged commit e59457b into flutter-team-archive:master Feb 1, 2021
@gaaclarke

gaaclarke commented Feb 1, 2021

Copy link
Copy Markdown
Contributor Author

Looks like changing from a draft to a reviewable PR resets presubmits history... They were passing.

christopherfujino added a commit that referenced this pull request Feb 10, 2021
…24306)

* Update Dart SDK to 2.12.0-259.9.beta
* Fixed plumbing of the spawning isolate for Shell::Spawn. (#24112)
* [canvaskit] update CSS size of the canvas when device-pixel ratio changes (#24160)
* [web] Fix text selection from right to left (#24214)
* [windows] Surface will not update when restoring (#24236)

Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
Co-authored-by: Yegor <yjbanov@google.com>
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants