Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Ensures that hit testing only returns focusable nodes.#23931

Merged
chinmaygarde merged 1 commit into
flutter-team-archive:masterfrom
abrush21:hit-testing
Jan 28, 2021
Merged

Ensures that hit testing only returns focusable nodes.#23931
chinmaygarde merged 1 commit into
flutter-team-archive:masterfrom
abrush21:hit-testing

Conversation

@abrush21

@abrush21 abrush21 commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

This PR fixes an issue with the hit test algorithm whereby it would prematurely stop searching for nodes that enclose the hit point. If a child that encloses the touch point is not focusable, the algorithm should move on to the next child.

fxb/68331

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla Bot added the cla: yes label Jan 25, 2021
@abrush21 abrush21 changed the title Ensures that hit testing only resturns focusable nodes. Ensures that hit testing only returns focusable nodes. Jan 25, 2021
dnfield
dnfield approved these changes Jan 25, 2021
View reviewed changes

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield

dnfield commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

See also:

b/162065967
cl/353656895
b/177271344

@chinmaygarde

chinmaygarde commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

@dnfield Can we land this?

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 28, 2021
@dnfield

dnfield commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

Yes - added the label

@chinmaygarde chinmaygarde merged commit 48e29fd into flutter-team-archive:master Jan 28, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
48e29fd Ensures that hit testing only resturns focusable nodes. (flut…
81722dc 
…ter-team-archive/engine#23931)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
48e29fd Ensures that hit testing only resturns focusable nodes. (flut…
87a28ce 
…ter-team-archive/engine#23931)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
48e29fd Ensures that hit testing only resturns focusable nodes. (flut…
fa9d0f6 
…ter-team-archive/engine#23931)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
48e29fd Ensures that hit testing only resturns focusable nodes. (flut…
a77e620 
…ter-team-archive/engine#23931)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
48e29fd Ensures that hit testing only resturns focusable nodes. (flut…
8d2c1fc 
…ter-team-archive/engine#23931)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
48e29fd Ensures that hit testing only resturns focusable nodes. (flut…
ded6d45 
…ter-team-archive/engine#23931)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@engine-flutter-autoroll
48e29fd Ensures that hit testing only resturns focusable nodes. (flut…
e223f34 
…ter-team-archive/engine#23931)
jamesr pushed a commit to jamesr/flutter_engine that referenced this pull request Feb 11, 2021
@abrush21 @jamesr
Ensures that hit testing only resturns focusable nodes. (flutter-team…
29ffba1 
…-archive#23931)
@pcsosinski pcsosinski mentioned this pull request Feb 12, 2021
Merged
2 tasks
pcsosinski pushed a commit to pcsosinski/engine that referenced this pull request Feb 12, 2021
@abrush21
Ensures that hit testing only resturns focusable nodes. (flutter-team…
bccd1c1 
…-archive#23931)
pcsosinski pushed a commit that referenced this pull request Feb 12, 2021
@abrush21
[flutter_releases] Flutter Engine 1.26.0-17.6.pre Beta Cherrypicks (#…
21fa8bb 
…24379)

* Update 1.26 engine to use Dart Dart 2.12.0-259.12.beta

* Ensures that hit testing only resturns focusable nodes. (#23931)

* update license file for Dart Dart 2.12.0-259.12.beta

Co-authored-by: Alexander Brusher <abrush21@users.noreply.github.com>
@jamesr jamesr mentioned this pull request Feb 12, 2021
Closed
jamesr pushed a commit to jamesr/flutter_engine that referenced this pull request Feb 13, 2021
@abrush21 @jamesr
Ensures that hit testing only resturns focusable nodes. (flutter-team…
3286c1d 
…-archive#23931)
@jamesr jamesr mentioned this pull request Feb 13, 2021
Merged
chaselatta pushed a commit that referenced this pull request Feb 13, 2021
@jamesr @abrush21
Ensures that hit testing only resturns focusable nodes. (#23931) (#24389
79b2a6a 
)

Co-authored-by: Alexander Brusher <abrush21@users.noreply.github.com>
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@abrush21 @hjfreyer
Ensures that hit testing only resturns focusable nodes. (flutter-team…
9bf48c7 
…-archive#23931)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@dnfield dnfield dnfield approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes cp: 1.26 waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abrush21 @dnfield @chinmaygarde @pcsosinski