This repository was archived by the owner on Feb 25, 2025. It is now read-only.
revert path volatility tracker#23822
Merged
Merged
Conversation
zanderso
approved these changes
Jan 21, 2021
zanderso
left a comment
zanderso
left a comment
Contributor
There was a problem hiding this comment.
Will this affect customer: money at all?
Contributor
Author
|
It will increase memory usage for rive animations. Unfortunately in its current state it causes increasing memory usage for some animations. |
dnfield
added
the
waiting for tree to go green
Contributor
Author
|
I'll add the bug for reference when I'm at my laptop |
Contributor
Author
|
Internal bug: b/176871072 I have a reproduction, going to work on trying to reduce it a bit further and will try to add it as a test here or in devicelab. Then I'll try to reland. |
Contributor
Author
|
I may have misdiagnosed this. Need to look into it a bit more. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 21, 2021
Contributor
Author
|
Ok, I think I have a clear, small reproduction now. This did in fact cause ap roblem for some paths. |
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Jan 21, 2021
This reverts commit e37235b.
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to have caused a regression in memory usage observed in an internal project.
I've reproduced that locally and will try to create a test to capture it and reland this.
@zanderso @chinmaygarde @jason-simmons