Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "[web] Enable the new rich paragraph implementation"#23651

Merged
zanderso merged 1 commit into
masterfrom
revert-23162-rich_enable
Jan 13, 2021
Merged

Revert "[web] Enable the new rich paragraph implementation"#23651
zanderso merged 1 commit into
masterfrom
revert-23162-rich_enable

Conversation

@zanderso

@zanderso zanderso commented Jan 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #23162

00:24 +15 -1: test/painting/text_painter_test.dart: TextPainter null text test [E]                                                                                                                     
  RangeError (index): Index out of range: no indices are valid: 0
  ../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 236:49      throw_
  ../dart-sdk/lib/_internal/js_dev_runtime/private/js_array.dart 581:7                 _get]
  ../lib/_engine/engine/text/layout_service.dart 77:41                                 performLayout
  ../lib/_engine/engine/text/canvas_paragraph.dart 90:20                               layout
  ../packages/flutter/src/painting/placeholder_span.dart.js 1136:40                    layout
  text_painter_test.dart.js 1951:15                                                    <fn>

@zanderso zanderso requested review from mdebbar and yjbanov January 13, 2021 16:55
@google-cla google-cla Bot added the cla: yes label Jan 13, 2021
@zanderso

zanderso commented Jan 13, 2021

Copy link
Copy Markdown
Contributor Author

Since this commit is a bit deep in the tree, I'll wait for all presubmits to finish.

@zanderso

zanderso commented Jan 13, 2021

Copy link
Copy Markdown
Contributor Author

Landing revert on red to unblock rolls.

@zanderso zanderso merged commit 859494f into master Jan 13, 2021
@zanderso zanderso deleted the revert-23162-rich_enable branch January 13, 2021 18:02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2021
@engine-flutter-autoroll
859494f Revert "[web] Enable the new rich paragraph implementation (f…
2b1f3e2 
…lutter#23162)" (flutter-team-archive/engine#23651)
@mdebbar mdebbar mentioned this pull request Jan 13, 2021
Merged
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 13, 2021
@engine-flutter-autoroll
Roll Engine from 10cee6a to 648dae9 (25 revisions) (#73886)
c9b991d 
* 51dd6aa [web] Enable the new rich paragraph implementation (flutter-team-archive/engine#23162)

* 0f9fc3d Roll Skia from 7cf3addb1bd8 to 93c2d81f199a (1 revision) (flutter-team-archive/engine#23614)

* a1e7424 [dart-runner] Avoid calling Destroy on nullptr (flutter-team-archive/engine#23608)

* 846d958 Windows textures: Add placeholder flutter_texture_registrar.h (flutter-team-archive/engine#23623)

* 55afc18 Roll Dart SDK from 7fcbd388b620 to ef8bf7f0a667 (5 revisions) (flutter-team-archive/engine#23628)

* d2b8154 [canvaskit] apply invser scale on the left (flutter-team-archive/engine#23550)

* be1a3c0 Roll Fuchsia Linux SDK from UB6RsTbdU... to FfWbbB4r8... (flutter-team-archive/engine#23633)

* f743c89 Roll Skia from 93c2d81f199a to 9fd75e96d712 (29 revisions) (flutter-team-archive/engine#23635)

* cf42dbe Roll wuffs to google/wuffs@c86add2 (flutter-team-archive/engine#23607)

* f1278d0 Link SkShaper/SkParagraph into the engine by default (flutter-team-archive/engine#23626)

* fb56b4b Android deeplink sends "path + query" instead of just path (flutter-team-archive/engine#23561)

* 22bb891 Plumbing refactor to allow the usage of Dart_CreateIsolateInGroup (flutter-team-archive/engine#23549)

* 20991a5 Add accessibility suport to Linux shell. (flutter-team-archive/engine#19634)

* 145922b Roll Dart SDK from ef8bf7f0a667 to 636ff0ec97e0 (1 revision) (flutter-team-archive/engine#23639)

* 176ae6e Roll Fuchsia Mac SDK from oll0Dgp9o... to JSzm8D59u... (flutter-team-archive/engine#23641)

* d2320a8 Roll Dart SDK from 636ff0ec97e0 to d3d7b77e8165 (1 revision) (flutter-team-archive/engine#23642)

* 8bdd099 Roll Skia from 9fd75e96d712 to 38ca513408d1 (1 revision) (flutter-team-archive/engine#23643)

* cc572e1 Roll Skia from 38ca513408d1 to be2a8614c5d6 (2 revisions) (flutter-team-archive/engine#23644)

* e9383a0 Roll Dart SDK from d3d7b77e8165 to 010633edc631 (1 revision) (flutter-team-archive/engine#23645)

* 9d6ed8b Roll Fuchsia Linux SDK from FfWbbB4r8... to BUsKF6z4t... (flutter-team-archive/engine#23646)

* 6d55dd4 Roll Dart SDK from 010633edc631 to 724d9e5e7d71 (1 revision) (flutter-team-archive/engine#23647)

* 299f081 Roll Skia from be2a8614c5d6 to 0d7de6bc9ac3 (1 revision) (flutter-team-archive/engine#23648)

* 0ec99cf Roll Fuchsia Mac SDK from JSzm8D59u... to BsUY1yjWh... (flutter-team-archive/engine#23650)

* 859494f Revert "[web] Enable the new rich paragraph implementation (#23162)" (flutter-team-archive/engine#23651)

* 648dae9 Roll Skia from 0d7de6bc9ac3 to 92969f265686 (7 revisions) (flutter-team-archive/engine#23652)
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 20, 2021
@zanderso @gspencergoog
Revert "[web] Enable the new rich paragraph implementation (flutter-t…
7abf4ad 
…eam-archive#23162)" (flutter-team-archive#23651)

This reverts commit 51dd6aa.
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@zanderso @hjfreyer
Revert "[web] Enable the new rich paragraph implementation (flutter-t…
01b03a0 
…eam-archive#23162)" (flutter-team-archive#23651)

This reverts commit 51dd6aa.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov
1 more reviewer
@mdebbar mdebbar mdebbar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @mdebbar