Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix background crash when FlutterView going appear while app goes background #23175

Merged
fluttergithubbot merged 2 commits into from
Jan 21, 2021
Merged

Fix background crash when FlutterView going appear while app goes background #23175

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3f9ab0
Fix background crash when FlutterView is being presented while app be…
pepsin Dec 18, 2020
ed528ec
If app not in foreground, don't send resume message
pepsin Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,9 @@ - (void)viewDidAppear:(BOOL)animated {
[[_engine.get() lifecycleChannel] sendMessage:@"AppLifecycleState.resumed"];

[super viewDidAppear:animated];
if (UIApplication.sharedApplication.applicationState == UIApplicationStateBackground) {

@chinmaygarde chinmaygarde Jan 7, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this case, shoudn't we just not sent the AppLifecycleState.resumed message?

@pepsin pepsin Jan 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's much better，will update the code.

[[_engine.get() lifecycleChannel] sendMessage:@"AppLifecycleState.paused"];
}
}

- (void)viewWillDisappear:(BOOL)animated {
Expand Down