Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make it easier to turn on Xcode symlinks #23150

Merged
fluttergithubbot merged 2 commits into from
Dec 17, 2020
Merged

Make it easier to turn on Xcode symlinks #23150

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c5a70
Make it easier to turn on Xcode symlinks
dnfield Dec 17, 2020
b17d36e
help text
dnfield Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,10 @@ def to_gn_args(args):
gn_args['use_goma'] = False
gn_args['goma_dir'] = None

if gn_args['use_goma']:
if args.xcode_symlinks:
gn_args['create_xcode_symlinks'] = True

# Enable Metal on iOS builds.
if args.target_os == 'ios':
gn_args['skia_use_metal'] = True
Expand Down Expand Up @@ -339,6 +343,8 @@ def parse_args(args):

parser.add_argument('--goma', default=True, action='store_true')
parser.add_argument('--no-goma', dest='goma', action='store_false')
parser.add_argument('--xcode-symlinks', action='store_true')

@xster xster Dec 17, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a help= for context?

@dnfield dnfield Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

parser.add_argument('--no-xcode-symlinks', dest='xcode_symlinks', default=False, action='store_false')
parser.add_argument('--depot-tools', default='~/depot_tools', type=str,
help='Depot tools provides an alternative location for gomacc in ' +
'/path/to/depot_tools/.cipd_bin')
Expand Down