Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] sharding change is merged. re-enable tests #22884

Merged
nturgut merged 2 commits into from
Dec 8, 2020
Merged

[web] sharding change is merged. re-enable tests #22884

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f3e8fc
sharding change is merged. re-enable tests
Dec 4, 2020
2351d1f
fix file name for image loading. re-block auto
Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 5 additions & 39 deletions lib/web_ui/dev/integration_tests_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,9 @@ class IntegrationTestsManager {
buildModes = <String>{mode};
}
} else {
// TODO(nurhan): Enable `release` when recipe is sharded.
buildModes = _browser == 'chrome'
? {'debug', 'profile'}
: {'profile'};
? {'debug', 'profile', 'release'}
: {'profile', 'release'};
}
return buildModes;
}
Expand Down Expand Up @@ -632,28 +631,9 @@ const Map<String, List<String>> blockedTestsListsMapForModes =
'treeshaking_integration.dart',
'text_editing_integration.dart',
'url_strategy_integration.dart',

// TODO(yjbanov): https://github.com/flutter/flutter/issues/71583
// The following tests are blocked to reduce the load on the build bot.
// The bot currently frequently exceeds the timeout limit.
'image_loading_integration.dart',
'platform_messages_integration.dart',
'profile_diagnostics_integration.dart',
'scroll_wheel_integration.dart',
],
'profile': [],
'release': [
// TODO(yjbanov): https://github.com/flutter/flutter/issues/71583
// The following tests are blocked to reduce the load on the build bot.
// The bot currently frequently exceeds the timeout limit.
'image_loading_integration.dart',
'platform_messages_integration.dart',
'profile_diagnostics_integration.dart',
'scroll_wheel_integration.dart',
'text_editing_integration.dart',
'treeshaking_integration.dart',
'url_strategy_integration.dart',
],
'release': [],
};

/// Tests blocked for one of the rendering backends.
Expand All @@ -663,24 +643,10 @@ const Map<String, List<String>> blockedTestsListsMapForModes =
// TODO(nurhan): Remove the failing test after fixing.
const Map<String, List<String>> blockedTestsListsMapForRenderBackends =
<String, List<String>>{
'auto': [
'image_loading_integration.dart',
'platform_messages_integration.dart',
'profile_diagnostics_integration.dart',
'scroll_wheel_integration.dart',
'text_editing_integration.dart',
'treeshaking_integration.dart',
'url_strategy_integration.dart',
],

@nturgut nturgut Dec 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yjbanov @hterkelsen is it useful to have these? I can also keep this list and not run these tests if we think html+canvaskit is enough?

'auto': [],
'html': [],
// This test failed on canvaskit on all three build modes.
'canvaskit': [
'image_loading_integration.dart',
'platform_messages_integration.dart',
'profile_diagnostics_integration.dart',
'scroll_wheel_integration.dart',
'text_editing_integration.dart',
'treeshaking_integration.dart',
'url_strategy_integration.dart',
'image_loading_integration',
],
};