Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add package:file to DEPS#22794

Merged
dcharkes merged 1 commit into
masterfrom
add-file-to-deps
Dec 1, 2020
Merged

Add package:file to DEPS#22794
dcharkes merged 1 commit into
masterfrom
add-file-to-deps

Conversation

@dcharkes

@dcharkes dcharkes commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

https://dart-review.googlesource.com/c/sdk/+/174382 added package:file to the DEPS in Dart.

In order to prevent these manual DEPS file fixes in the future, we should make https://github.com/flutter/buildroot/blob/master/tools/dart/create_updated_flutter_deps.py deal with new dependencies. (Tracked in flutter/flutter#71474.)

Description

Adds package:file to the DEPS file, in correspondence to https://dart-review.googlesource.com/c/sdk/+/174382.

Related Issues

Failing Dart Flutter HHH build: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-engine-linux/12295/overview

Tests

No new tests, this fixes the build.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@dcharkes

dcharkes commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

Make sure your PR passes all the pre-commit tests.

Wait for Cirrus to give the green light before merging a PR. Cirrus runs a bunch of pre-commit checks

The Linux Android Scenarios bot is consistently infra failing.

Running from /b/s/w/ir/cache/builder/src/flutter/testing/scenario_app/android/gradle-home/bin/bin/python
Copying file:///b/s/w/ir/k/recipe_cleanup/tmpHunuG3/diff_failures.zip [Content-Type=application/zip]...
/ [0 files][    0.0 B/  1.0 MiB]                                                
AccessDeniedException: 403 flutter-try-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to flutter_infra/flutter//diff_failures.zip.

@dcharkes dcharkes added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 1, 2020
@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Android Scenarios has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 1, 2020
@dcharkes

dcharkes commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

The infra failure is the last step of Linux Android Scenarios, and does not indicate a problem with this CL.

This CL restores HHH and Golem coverage, so we're landing this despite Linux Android Scenarios not being green.

@dcharkes dcharkes merged commit 747b791 into master Dec 1, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2020
cbracken pushed a commit to flutter/flutter that referenced this pull request Dec 1, 2020
* d6beaed Roll Fuchsia Linux SDK from gkfmiRsIl... to un3JixwuO... (flutter-team-archive/engine#22744)

* 8832b48 Roll Skia from 888c5d3e57eb to 51b74afb84d4 (12 revisions) (flutter-team-archive/engine#22746)

* e890901 Don't register CanvasKit with `define` (flutter-team-archive/engine#22745)

* 3c51679 Roll Skia from 51b74afb84d4 to 452369182f6e (1 revision) (flutter-team-archive/engine#22749)

* 5bf6533 Introduce a delegate class for gpu metal rendering (flutter-team-archive/engine#22611)

* 5131aa4 Roll Skia from 452369182f6e to f2efb80bc316 (4 revisions) (flutter-team-archive/engine#22750)

* 7b5f79f fuchsia: Ensure full-screen input interceptor (flutter-team-archive/engine#22687)

* cec8a6e Manual roll of Dart SDK from ce76503f5b46 to dcd5a8f005a (flutter-team-archive/engine#22766)

* 001a511 Roll Fuchsia Linux SDK from un3JixwuO... to Bnaeivv07... (flutter-team-archive/engine#22757)

* b9615b1 Roll Fuchsia Mac SDK from 36uDTGJQp... to qpkZl0s5J... (flutter-team-archive/engine#22753)

* c4c4763 Roll Skia from f2efb80bc316 to 8d78da910e45 (5 revisions) (flutter-team-archive/engine#22754)

* dbd1abe Roll Dart SDK from dcd5a8f005a2 to 960620d2e811 (794 revisions) (flutter-team-archive/engine#22768)

* 1c2a6bd Fix the unchecked conversion warning for searchPaths in PlayStoreDynamicFeatureManager (flutter-team-archive/engine#22654)

* 81af789 add file package to deps in prep for glob update (flutter-team-archive/engine#22770)

* a35e3fe Let FlutterFragment not pop the whole activity by default when more fragments are in the activity (flutter-team-archive/engine#22692)

* adb3312 Revert "Introduce a delegate class for gpu metal rendering (#22611)" (flutter-team-archive/engine#22775)

* bcc8832 Cleanup dart_runner examples & tests. (flutter-team-archive/engine#22769)

* 609307d Roll Skia from 8d78da910e45 to fd41d878b13d (20 revisions) (flutter-team-archive/engine#22772)

* 587c023 [web] Add new line break type (prohibited) (flutter-team-archive/engine#22771)

* 6b2ed2b Roll Skia from fd41d878b13d to 70fe17e12f38 (6 revisions) (flutter-team-archive/engine#22776)

* 7910a17 Roll Dart SDK from 960620d2e811 to 7a2a3968ef53 (12 revisions) (flutter-team-archive/engine#22778)

* f4ada80 Roll Skia from 70fe17e12f38 to 4c6f57a23e63 (1 revision) (flutter-team-archive/engine#22781)

* 3101dff [web] Optimize Matrix4.identity (flutter-team-archive/engine#22622)

* a4ce848 Add FlutterPlayStoreSplitApplication for simpler opt in to Split AOT (flutter-team-archive/engine#22752)

* 747b791 Add file.dart to DEPS (flutter-team-archive/engine#22794)

* 40fa345 Fix race condition in key event handling on Android (flutter-team-archive/engine#22658)

* d2ad441 Fix PlatformDispatcher.locale to return something meaningful when there are no locales. (flutter-team-archive/engine#22608)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 4, 2020
cbracken pushed a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 4, 2020
cbracken pushed a commit to flutter/flutter that referenced this pull request Dec 4, 2020
* d6beaed Roll Fuchsia Linux SDK from gkfmiRsIl... to un3JixwuO... (flutter-team-archive/engine#22744)

* 8832b48 Roll Skia from 888c5d3e57eb to 51b74afb84d4 (12 revisions) (flutter-team-archive/engine#22746)

* e890901 Don't register CanvasKit with `define` (flutter-team-archive/engine#22745)

* 3c51679 Roll Skia from 51b74afb84d4 to 452369182f6e (1 revision) (flutter-team-archive/engine#22749)

* 5bf6533 Introduce a delegate class for gpu metal rendering (flutter-team-archive/engine#22611)

* 5131aa4 Roll Skia from 452369182f6e to f2efb80bc316 (4 revisions) (flutter-team-archive/engine#22750)

* 7b5f79f fuchsia: Ensure full-screen input interceptor (flutter-team-archive/engine#22687)

* cec8a6e Manual roll of Dart SDK from ce76503f5b46 to dcd5a8f005a (flutter-team-archive/engine#22766)

* 001a511 Roll Fuchsia Linux SDK from un3JixwuO... to Bnaeivv07... (flutter-team-archive/engine#22757)

* b9615b1 Roll Fuchsia Mac SDK from 36uDTGJQp... to qpkZl0s5J... (flutter-team-archive/engine#22753)

* c4c4763 Roll Skia from f2efb80bc316 to 8d78da910e45 (5 revisions) (flutter-team-archive/engine#22754)

* dbd1abe Roll Dart SDK from dcd5a8f005a2 to 960620d2e811 (794 revisions) (flutter-team-archive/engine#22768)

* 1c2a6bd Fix the unchecked conversion warning for searchPaths in PlayStoreDynamicFeatureManager (flutter-team-archive/engine#22654)

* 81af789 add file package to deps in prep for glob update (flutter-team-archive/engine#22770)

* a35e3fe Let FlutterFragment not pop the whole activity by default when more fragments are in the activity (flutter-team-archive/engine#22692)

* adb3312 Revert "Introduce a delegate class for gpu metal rendering (#22611)" (flutter-team-archive/engine#22775)

* bcc8832 Cleanup dart_runner examples & tests. (flutter-team-archive/engine#22769)

* 609307d Roll Skia from 8d78da910e45 to fd41d878b13d (20 revisions) (flutter-team-archive/engine#22772)

* 587c023 [web] Add new line break type (prohibited) (flutter-team-archive/engine#22771)

* 6b2ed2b Roll Skia from fd41d878b13d to 70fe17e12f38 (6 revisions) (flutter-team-archive/engine#22776)

* 7910a17 Roll Dart SDK from 960620d2e811 to 7a2a3968ef53 (12 revisions) (flutter-team-archive/engine#22778)

* f4ada80 Roll Skia from 70fe17e12f38 to 4c6f57a23e63 (1 revision) (flutter-team-archive/engine#22781)

* 3101dff [web] Optimize Matrix4.identity (flutter-team-archive/engine#22622)

* a4ce848 Add FlutterPlayStoreSplitApplication for simpler opt in to Split AOT (flutter-team-archive/engine#22752)

* 747b791 Add file.dart to DEPS (flutter-team-archive/engine#22794)

* 40fa345 Fix race condition in key event handling on Android (flutter-team-archive/engine#22658)

* d2ad441 Fix PlatformDispatcher.locale to return something meaningful when there are no locales. (flutter-team-archive/engine#22608)

* b9a0b5e Roll Skia from 4c6f57a23e63 to a927771c9cce (10 revisions) (flutter-team-archive/engine#22802)

* 96d63e5 Roll Dart SDK from 7a2a3968ef53 to e9a03fd98faa (5 revisions) (flutter-team-archive/engine#22801)

* cdf72da Roll Skia from a927771c9cce to 7b776b514933 (3 revisions) (flutter-team-archive/engine#22803)

* a0c8b67 Roll buildroot and benchmark (flutter-team-archive/engine#22804)

* c3c3ec6 Roll Fuchsia Mac SDK from qpkZl0s5J... to 7O11wjLVX... (flutter-team-archive/engine#22805)

* 6625308 Revert "Roll buildroot and benchmark (#22804)" (flutter-team-archive/engine#22816)

* 64d9add Add a golden scenario test for fallback font rendering on iOS take 3 (flutter-team-archive/engine#22736)

* 7d7a260 Add static text trait to plain semantics object with label in iOS (flutter-team-archive/engine#22811)

* 22e1143 Roll Skia from 7b776b514933 to c504ecda03b8 (6 revisions) (flutter-team-archive/engine#22808)

* 65254eb Roll Dart SDK from e9a03fd98faa to 5acaa5f14b03 (1 revision) (flutter-team-archive/engine#22810)

* 3926b21 Roll Fuchsia Linux SDK from Bnaeivv07... to W14Qninrb... (flutter-team-archive/engine#22817)

* 5eb505f Roll Fuchsia Mac SDK from 7O11wjLVX... to Z_-ciOYM9... (flutter-team-archive/engine#22820)

* d85cb10 add trace kernel flag to allowlist (flutter-team-archive/engine#22812)

* 14cb066 [embedder] Compositor can specify that no backing stores be cached (flutter-team-archive/engine#22780)

* eb6eabc Reland "Introduce a delegate class for gpu metal rendering (#22611)" (flutter-team-archive/engine#22777)

* 644dd65 Temporarily reduce e2e test matrix to stop flaky web engine builds (flutter-team-archive/engine#22824)

* 105004d Stop using the List constructor. (flutter-team-archive/engine#22793)

* 34f49a1 Roll Dart SDK from 5acaa5f14b03 to cfaa7606cbf5 (2 revisions) (flutter-team-archive/engine#22827)

* 6c8342f Revert "Fix race condition in key event handling on Android (#22658)" (flutter-team-archive/engine#22823)

* 1c2a8f9 Roll Skia from c504ecda03b8 to 9443d58af292 (16 revisions) (flutter-team-archive/engine#22828)

* b63e911 Better handle image codec instantiation failure (flutter-team-archive/engine#22809)

* 1358fda Generate Maven metadata files for engine artifacts (flutter-team-archive/engine#22685)

* 079c669 Generate gen_snapshot_armv7 and gen_snapshot_arm64 (flutter-team-archive/engine#22818)

* fcbfa9f Split AOT Engine Runtime (flutter-team-archive/engine#22624)

* 24d289e Roll Fuchsia Linux SDK from W14Qninrb... to M_8svVndh... (flutter-team-archive/engine#22842)

* 78b567f Reland: "Fix race condition in key event handling on Android (#22658)" (flutter-team-archive/engine#22834)

* 7d32cea (MacOS) Add FlutterGLCompositor with support for rendering multiple layers (flutter-team-archive/engine#22782)

* a713174 Roll Skia from 9443d58af292 to c7112edbe0f4 (10 revisions) (flutter-team-archive/engine#22839)

* bee352c Roll Dart SDK from cfaa7606cbf5 to 97cfd05b3cb3 (2 revisions) (flutter-team-archive/engine#22840)

* e5f510f [web] Fix event transform between mousedown/up due to mouse move event (flutter-team-archive/engine#22813)

* 04b98dc Roll Fuchsia Mac SDK from Z_-ciOYM9... to DRN4P3zbe... (flutter-team-archive/engine#22841)

* 0e3b2cf Roll Skia from c7112edbe0f4 to d39aec0e40ec (17 revisions) (flutter-team-archive/engine#22844)

* e71c6f4 leaving only html tests (flutter-team-archive/engine#22846)

* 3773835 Make CkPicture resurrectable (flutter-team-archive/engine#22807)

* bd394a1 Roll Skia from d39aec0e40ec to 38921cafe1bb (7 revisions) (flutter-team-archive/engine#22847)

* 66f44c6 Roll Dart SDK from 97cfd05b3cb3 to a37a4d42e53d (4 revisions) (flutter-team-archive/engine#22849)

* bdadaad Add delayed event delivery for Linux. (flutter-team-archive/engine#22577)

* 48befc5 More rename from GPU thread to raster thread (flutter-team-archive/engine#22819)

* 9b1b7f6 Roll Skia from 38921cafe1bb to abcc1ecdfd0c (8 revisions) (flutter-team-archive/engine#22851)

* 14a6fd9 Fix NPE when platform plugin delegate is null (flutter-team-archive/engine#22852)
@cbracken cbracken deleted the add-file-to-deps branch May 10, 2022 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants