[flutter_releases] Flutter 1.24.0-10.1.pre engine cherrypicks

DEPS

@@ -34,7 +34,7 @@ vars = {
   # Dart is: https://github.com/dart-lang/sdk/blob/master/DEPS.
   # You can use //tools/dart/create_updated_flutter_deps.py to produce
   # updated revision list of existing dependencies.
-  'dart_revision': '26219fa05863420b5811ef509663ee13bc7432eb',
+  'dart_revision': '6fee8e27b8206acd82cd7ed6204941916a2568e5',
 
   # WARNING: DO NOT EDIT MANUALLY
   # The lines between blank lines above and below are generated by a script. See create_updated_flutter_deps.py

shell/platform/darwin/macos/framework/Source/FlutterEngine.mm

@@ -322,7 +322,6 @@ - (BOOL)runWithEntrypoint:(NSString*)entrypoint {
   [self sendUserLocales];
   [self updateWindowMetrics];
   [self updateDisplayConfig];
-  self.viewController.flutterView.synchronousResizing = YES;
   return YES;
 }
 
@@ -359,9 +358,6 @@ - (void)setViewController:(FlutterViewController*)controller {
     [self shutDownEngine];
     _resourceContext = nil;
   }
-  if (_engine) {
-    self.viewController.flutterView.synchronousResizing = YES;
-  }
 }
 
 - (id<FlutterBinaryMessenger>)binaryMessenger {

shell/platform/darwin/macos/framework/Source/FlutterResizeSynchronizer.mm

@@ -17,6 +17,10 @@ @interface FlutterResizeSynchronizer () {
   // Used to block [requestCommit].
   std::condition_variable _condBlockRequestCommit;
 
+  // Whether a frame was received; We don't block platform thread during resize
+  // until we know that framework is running and producing frames
+  BOOL _receivedFirstFrame;
+
   // If NO, requestCommit calls are ignored until shouldEnsureSurfaceForSize is called with
   // proper size.
   BOOL _acceptingCommit;
@@ -50,6 +54,12 @@ - (void)beginResize:(CGSize)size notify:(dispatch_block_t)notify {
     return;
   }
 
+  if (!_receivedFirstFrame) {
+    // No blocking until framework produces at least one frame
+    notify();
+    return;
+  }
+
   ++_cookie;
 
   // from now on, ignore all incoming commits until the block below gets
@@ -79,6 +89,11 @@ - (void)beginResize:(CGSize)size notify:(dispatch_block_t)notify {
 
 - (BOOL)shouldEnsureSurfaceForSize:(CGSize)size {
   std::unique_lock<std::mutex> lock(_mutex);
+
+  if (!_receivedFirstFrame) {
+    return YES;
+  }
+
   if (!_acceptingCommit) {
     if (CGSizeEqualToSize(_newSize, size)) {
       _acceptingCommit = YES;
@@ -93,6 +108,8 @@ - (void)requestCommit {
     return;
   }
 
+  _receivedFirstFrame = YES;
+
   _pendingCommit = YES;
   if (_waiting) {  // BeginResize is in progress, interrupt it and schedule commit call
     _condBlockRequestCommit.notify_all();

shell/platform/darwin/macos/framework/Source/FlutterView.h

@@ -25,13 +25,6 @@
  */
 @property(readwrite, nonatomic, nonnull) NSOpenGLContext* openGLContext;
 
-/**
- * Controls whether view resizing synchronously updates contents. This can only be enabled
- * after the engine is running and producing frames, because during synchronous view resizing the
- * platform thread is blocked until engine produces frame with requested size.
- */
-@property(readwrite, nonatomic) BOOL synchronousResizing;
-
 - (nullable instancetype)initWithFrame:(NSRect)frame
                           shareContext:(nonnull NSOpenGLContext*)shareContext
                        reshapeListener:(nonnull id<FlutterViewReshapeListener>)reshapeListener

shell/platform/darwin/macos/framework/Source/FlutterView.mm

@@ -71,15 +71,11 @@ - (void)present {
 }
 
 - (void)reshaped {
-  if (self.synchronousResizing) {
-    CGSize scaledSize = [self convertSizeToBacking:self.bounds.size];
-    [_resizeSynchronizer beginResize:scaledSize
-                              notify:^{
-                                [_reshapeListener viewDidReshape:self];
-                              }];
-  } else {
-    [_reshapeListener viewDidReshape:self];
-  }
+  CGSize scaledSize = [self convertSizeToBacking:self.bounds.size];
+  [_resizeSynchronizer beginResize:scaledSize
+                            notify:^{
+                              [_reshapeListener viewDidReshape:self];
+                            }];
 }
 
 #pragma mark - NSView overrides

tools/generate_package_config/bin/generate_from_legacy.dart

@@ -46,10 +46,10 @@ void main(List<String> args) async {
       if (!File.fromUri(pubspec).existsSync()) {
         continue;
       }
-      // Default to 2.8 if not found to prevent all packages from accidentally
+      // Default to 2.7 if not found to prevent all packages from accidentally
       // opting into NNBD.
       languageVersion = await languageVersionFromPubspec(pubspec, name) ??
-          LanguageVersion(2, 8);
+          LanguageVersion(2, 7);
       packages.add(Package(name, packageRoot,
           languageVersion: languageVersion, packageUriRoot: uri));
     }