Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[flutter_releases] Flutter 1.22.4 engine cherrypicks#22449

Merged
christopherfujino merged 8 commits into
flutter-team-archive:flutter-1.22-candidate.12from
christopherfujino:cherrypicks-flutter-1.22-candidate.12
Nov 12, 2020
Merged

[flutter_releases] Flutter 1.22.4 engine cherrypicks#22449
christopherfujino merged 8 commits into
flutter-team-archive:flutter-1.22-candidate.12from
christopherfujino:cherrypicks-flutter-1.22-candidate.12

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

previous build

Scheduled Cherrypicks

Known Presubmit Failures

Known Postsubmit Failures

@flutter-dashboard flutter-dashboard Bot changed the base branch from flutter-1.22-candidate.12 to master November 11, 2020 21:47
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 November 11, 2020 21:51

@pcsosinski pcsosinski left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for branch

@cyanglaz cyanglaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on fb72023 and 122f242

@LongCatIsLooong

Copy link
Copy Markdown
Contributor

3f27800 LGTM

@christopherfujino

Copy link
Copy Markdown
Contributor Author

All outstanding CI failures accounted for in description (and they're the same as the previous build), so merging this.

@christopherfujino christopherfujino merged commit bba39d2 into flutter-team-archive:flutter-1.22-candidate.12 Nov 12, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch November 12, 2020 17:49
@christopherfujino

christopherfujino commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

This PR required a follow-up fix, #22478

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

5 participants