This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Pass platform configuration to Dart VM for insecure socket policy"#20828
Closed
mehmetf wants to merge 2 commits into
Closed
Reland "Pass platform configuration to Dart VM for insecure socket policy"#20828mehmetf wants to merge 2 commits into
mehmetf wants to merge 2 commits into
Conversation
flutter-dashboard
Bot
changed the base branch from
flutter-1.22-candidate.7
to
master
August 27, 2020 21:16
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20818
This is now able to reland because we fixed a
package:grpcissue whereSecureSocket.secure()method was being unnecessarily used instead ofSecureSocket.connect(). Also see dart-lang/sdk#43223.