This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix shadows and mask filter blurs#16963
Merged
Merged
Conversation
ferhatb
approved these changes
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
This was referenced Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
This was referenced Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
This was referenced Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
Contributor
|
This appears to break golden file tests when rolling to the framework. Roll: flutter/flutter#52165 |
Contributor
|
I'm going to revert this to get the roll through but when you're ready to re-land, we can deal with the golden file updates. |
cbracken
added a commit
that referenced
this pull request
Mar 7, 2020
Contributor
|
Revert landed and re-opened flutter/flutter#32215 until we re-land. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 7, 2020
* 7c612de Roll fuchsia/sdk/core/linux-amd64 from cXgMr... to cTw2C... (flutter-team-archive/engine#16970) * 6cfa7fc fix shadows and mask filter blurs (flutter-team-archive/engine#16963) * bfebadf Roll src/third_party/skia 012f8497802e..93a2a6b8badb (4 commits) (flutter-team-archive/engine#16974) * 47963a5 Roll src/third_party/skia 93a2a6b8badb..74055566bd14 (2 commits) (flutter-team-archive/engine#16981) * 98f9941 [fuchsia] fix broken flows when under high load (flutter-team-archive/engine#16834) * fe051e0 Fix issue viewdidload call while init FlutterViewController (flutter-team-archive/engine#16672) * 0ad54c2 [web] Fixes IE11 crash due to missing canvas ellipse support and font polyfill failure (flutter-team-archive/engine#16965) * f6435de Roll fuchsia/sdk/core/mac-amd64 from J6ct_... to 95geB... (flutter-team-archive/engine#16982) * 43971ca Roll src/third_party/skia 74055566bd14..54de2fa48d85 (3 commits) (flutter-team-archive/engine#16983) * 45e61a6 Roll fuchsia/sdk/core/linux-amd64 from cTw2C... to K1wwe... (flutter-team-archive/engine#16984) * 1ab5c36 Roll src/third_party/skia 54de2fa48d85..beaaf4700f50 (3 commits) (flutter-team-archive/engine#16987) * e2c0454 remove 10s timeouts from tests (flutter-team-archive/engine#16988) * dfc9c12 Roll src/third_party/skia beaaf4700f50..6e58290ba639 (9 commits) (flutter-team-archive/engine#16990) * eddda80 fushia licenses fix (flutter-team-archive/engine#16992) * c15f239 documented fluttertexture.h (flutter-team-archive/engine#16950) * e1ba7a1 Roll src/third_party/skia 6e58290ba639..24a8e9e170f7 (5 commits) (flutter-team-archive/engine#16996) * fc5963d [web] Engine integration test (flutter-team-archive/engine#16930) * d323bac doxygen tooling updates and doxygen for FlutterCodecs.h (flutter-team-archive/engine#16947) * 03ddc1d Started deleting .DS_Store files so licenses can run on mac os x. (flutter-team-archive/engine#16998) * 30a8292 Roll src/third_party/skia 24a8e9e170f7..cf573d844da6 (4 commits) (flutter-team-archive/engine#17004) * d031963 Roll fuchsia/sdk/core/mac-amd64 from 95geB... to hW33F... (flutter-team-archive/engine#17006) * 41b371d Roll fuchsia/sdk/core/linux-amd64 from K1wwe... to FGMpI... (flutter-team-archive/engine#17007) * 619acd5 Revert "fix shadows and mask filter blurs (#16963)" (flutter-team-archive/engine#17008)
yjbanov
added a commit
to yjbanov/engine
that referenced
this pull request
Mar 9, 2020
…ve#16963)" (flutter-team-archive#17008)" This reverts commit 619acd5.
blasten
pushed a commit
to blasten/engine
that referenced
this pull request
Mar 10, 2020
* fix shadows and mask filter blurs * update goldens * clarify the choice to min the shadows
blasten
pushed a commit
to blasten/engine
that referenced
this pull request
Mar 10, 2020
…" (flutter-team-archive#17008) Broke golden file tests in the framework. Reverting to unblock the engine roll to the framework. This reverts commit 6cfa7fc.
yjbanov
added a commit
that referenced
this pull request
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our original implementation of shadows was based on the AngularDart version, which doesn't match Flutter at all.
physical_shape_layer.cc(not 100% as we don't get to use Skia'sDrawShadowdirectly). Rendering should be slightly faster too as we emulate it using a single shadow rather than 3 shadows from the previous implementation.drawShadow.Paintwith a mask filter blur (some users use mask filters to draw shadows instead of physica shapes orcanvas.drawShadow).Fixes flutter/flutter#32215