Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix bounds of image_filter_layer#16960

Merged
flar merged 1 commit into
flutter-team-archive:masterfrom
flar:imagefiltered-bounds-fix
Mar 9, 2020
Merged

Fix bounds of image_filter_layer#16960
flar merged 1 commit into
flutter-team-archive:masterfrom
flar:imagefiltered-bounds-fix

Conversation

@flar

@flar flar commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Fix for flutter/flutter#51978

The paint_bounds of the image_filter_layer need to query the filter itself to adjust the bounds. A new test to verify that the filter is applied to the bounds is included.

Additionally, the existing tests for image_filter_layer had to be updated because the true bounds of a filtered layer will be rounded out to the nearest pixel boundary.

@auto-assign auto-assign Bot requested a review from gaaclarke March 5, 2020 21:29
@flar flar requested a review from liyuqian March 5, 2020 21:30
@flar flar force-pushed the imagefiltered-bounds-fix branch from 2e0296e to 9f6e6bb Compare March 5, 2020 22:55
@flar flar changed the title Fix bounds of image_filter_layer (https://github.com/flutter/flutter/issues/51978) Fix bounds of image_filter_layer Mar 6, 2020
liyuqian
liyuqian approved these changes Mar 9, 2020
View reviewed changes

@liyuqian liyuqian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flar flar merged commit 8b6119e into flutter-team-archive:master Mar 9, 2020
@flar flar mentioned this pull request Mar 9, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
f93c3ff 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
blasten pushed a commit to blasten/engine that referenced this pull request Mar 10, 2020
@flar
Fix bounds of image_filter_layer (flutter-team-archive#16960)
0b34b78
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
b43297f 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
cb99ceb 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
5e600c2 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
2931c9d 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
6eb7411 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
2b4948f 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
b4cdb6d 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
flar added a commit that referenced this pull request Mar 10, 2020
@flar
Revert "Fix bounds of image_filter_layer (#16960)"
abecc66 
This reverts commit 8b6119e.
@flar flar mentioned this pull request Mar 10, 2020
Merged
flar added a commit that referenced this pull request Mar 10, 2020
@flar
Revert "Fix bounds of image_filter_layer (#16960)" (#17074)
220039a 
This reverts commit 8b6119e.
@flar flar mentioned this pull request Mar 10, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
aa435f8 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
4d993f4 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
52a07b3 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
3ed2e38 
…#16960)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
1f8938b 
…#16960)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
85c04d4 
…#16960)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
10ea68d 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
63d49bf 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
f5d5fb8 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
cd402fe 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
8b6119e Fix bounds of image_filter_layer (flutter-team-archive/engine…
a21180e 
…#16960)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits)
449aea9 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter-team-archive/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter-team-archive/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter-team-archive/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter-team-archive/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter-team-archive/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (flutter#17080)" (flutter-team-archive/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter-team-archive/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter-team-archive/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter-team-archive/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter-team-archive/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter-team-archive/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter-team-archive/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter-team-archive/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter-team-archive/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter-team-archive/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (flutter#16960)" (flutter-team-archive/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter-team-archive/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter-team-archive/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter-team-archive/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter-team-archive/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter-team-archive/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (flutter#16963)" (flutter#17008)" (flutter-team-archive/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter-team-archive/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter-team-archive/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter-team-archive/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter-team-archive/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter-team-archive/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter-team-archive/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter-team-archive/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter-team-archive/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter-team-archive/engine#17032)
@jason-simmons jason-simmons mentioned this pull request Mar 11, 2020
Merged
13 tasks
jason-simmons added a commit to flutter/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits) (#52431)
5e74b00 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter-team-archive/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter-team-archive/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter-team-archive/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter-team-archive/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter-team-archive/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (#17080)" (flutter-team-archive/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter-team-archive/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter-team-archive/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter-team-archive/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter-team-archive/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter-team-archive/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter-team-archive/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter-team-archive/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter-team-archive/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter-team-archive/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (#16960)" (flutter-team-archive/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter-team-archive/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter-team-archive/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter-team-archive/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter-team-archive/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter-team-archive/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter-team-archive/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter-team-archive/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter-team-archive/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter-team-archive/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter-team-archive/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter-team-archive/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter-team-archive/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter-team-archive/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter-team-archive/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter-team-archive/engine#17032)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gaaclarke gaaclarke Awaiting requested review from gaaclarke
1 more reviewer
@liyuqian liyuqian liyuqian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flar @liyuqian @googlebot