This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Use ELF for Dart AOT snapshots on Fuchsia. (#13896)"#14823
Merged
franciscojma86 merged 1 commit intoDec 28, 2019
Conversation
…ive#13896)" This reverts commit 09c434d.
chingjun
approved these changes
Dec 27, 2019
chingjun
left a comment
chingjun
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I've verified that this is causing failure in some internal tests.
Contributor
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 28, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 28, 2019
flutter-team-archive/engine@5a730c6...bdc9708 git log 5a730c6..bdc9708 --first-parent --oneline 2019-12-28 franciscojma86@gmail.com Revert "Use ELF for Dart AOT snapshots on Fuchsia. (#13896)" (flutter-team-archive/engine#14823) 2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia 89bf1547f3aa..5a2f962313a5 (16 commits) (flutter-team-archive/engine#14825) 2019-12-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from ikxBh... to sxapd... (flutter-team-archive/engine#14821) 2019-12-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IEPKx... to iImpF... (flutter-team-archive/engine#14817) 2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/dart 94a4f6415e6c..c547f5d933e5 (9 commits) (flutter-team-archive/engine#14812) 2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia f2d522a3f434..89bf1547f3aa (4 commits) (flutter-team-archive/engine#14814) 2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 232a171a0b1c..94a4f6415e6c (8 commits) (flutter-team-archive/engine#14808) 2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 07d744fb8a53..f2d522a3f434 (4 commits) (flutter-team-archive/engine#14807) 2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 05eb83be171c..07d744fb8a53 (3 commits) (flutter-team-archive/engine#14806) 2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v3R8A... to ikxBh... (flutter-team-archive/engine#14802) 2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 75fc15c7e186..232a171a0b1c (4 commits) (flutter-team-archive/engine#14803) 2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from ZA31z... to IEPKx... (flutter-team-archive/engine#14702) 2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d3150c89c5f..05eb83be171c (3 commits) (flutter-team-archive/engine#14800) 2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia a2d7225c0fc1..3d3150c89c5f (1 commits) (flutter-team-archive/engine#14680) 2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter-team-archive/engine#14679) 2019-12-24 liyuqian@google.com Run and collect benchmarks (flutter-team-archive/engine#14556) 2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter-team-archive/engine#14678) 2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter-team-archive/engine#14677) 2019-12-23 nurhan@google.com fix selection issue (flutter-team-archive/engine#14604) 2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter-team-archive/engine#14670) 2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter-team-archive/engine#14671) 2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter-team-archive/engine#14672) 2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter-team-archive/engine#14675) 2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter-team-archive/engine#14667) 2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter-team-archive/engine#14665) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Contributor
Author
|
@chingjun do you have a link to which tests were broken (for future archeology)? |
Contributor
|
b/147313723 |
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 09c434d.
This breaks the fuchsia roll