This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Long press fix on Safari on IOS#14588
Merged
Merged
Conversation
mdebbar
approved these changes
Dec 20, 2019
mdebbar
left a comment
mdebbar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this long-standing issue!
Contributor
Author
|
I am merging since the breakage is in Fushia (unrelated to the web engine) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2019
flar
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 21, 2019
* 399a29e Roll src/third_party/dart 141fcfa61092..4681868aaf77 (9 commits) (flutter-team-archive/engine#14590) * 97fd705 Roll src/third_party/skia 7e2dea568299..dcac29b02d02 (3 commits) (flutter-team-archive/engine#14591) * 6d92887 Roll src/third_party/dart 4681868aaf77..b92fefdfe971 (1 commits) (flutter-team-archive/engine#14592) * 4d7313f Roll fuchsia/sdk/core/mac-amd64 from f51Q_... to VC7eE... (flutter-team-archive/engine#14593) * fac66c2 [web] Long press fix on Safari on IOS (flutter-team-archive/engine#14588) * 32eb6e9 Roll src/third_party/skia dcac29b02d02..088913a63b7e (1 commits) (flutter-team-archive/engine#14597) * ede1b6b Roll fuchsia/sdk/core/linux-amd64 from 25LzW... to TUoVa... (flutter-team-archive/engine#14596) * cce5afd Roll src/third_party/dart b92fefdfe971..886615d0f95b (2 commits) (flutter-team-archive/engine#14595) * 9b299f2 fix editable placement in a11y mode (flutter-team-archive/engine#14581) * 3381392 [web] implement pushImageFilter (flutter-team-archive/engine#14599)
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* fixing long press by listening click * documenting the code. creating a new method * addressing reviewer comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long press in IOS does not bring the virtual keyboard but still focus on the dom element. After this if a user taps on the input element the virtual keyboard will shift the page up. (the video I recorded turned out to be to big for github so I am not adding it here.)
in order to fix this, i added one more listener. this time for the click. this listener carries the input field temporarily out of the visible page to prevent shifting.
fixing eap issue: flutter/flutter#41638