Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove unused _TypeNone enum field. #14440

Merged
aam merged 3 commits into from
Dec 12, 2019
+0 −4
Merged

Remove unused _TypeNone enum field. #14440

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
101abba
Add hint to analyzer regarding unused field.
aam Dec 12, 2019
2883ace
Remove unused field
aam Dec 12, 2019
1bc67e8
Similarly remove _TypeNone from web_ui
aam Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/ui/painting.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2633,6 +2633,7 @@ class ColorFilter {

// The type of SkColorFilter class to create for Skia.
// These constants must be kept in sync with ColorFilterType in paint.cc.

@dnfield dnfield Dec 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is no longer true and should just be removed.

@aam aam Dec 12, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// ignore:unused_field
static const int _TypeNone = 0; // null

@dnfield dnfield Dec 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding an ignore, let's just remove the unused field.

We should also do the same in the web_ui painting.dart

@aam aam Dec 12, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no _TypeNone in web_ui painting.dart as far as I can tell

@aam aam Dec 12, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding an ignore, let's just remove the unused field.

Done

@dnfield dnfield Dec 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in lib/web_ui/lib/src/engine/color_filter.dart, line 118

@aam aam Dec 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got you. Interestingly this is not picked up by analyzer as unused field.

static const int _TypeMode = 1; // MakeModeFilter
static const int _TypeMatrix = 2; // MakeMatrixFilterRowMajor255
Expand Down