Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix missing API stream when record event in systrace#14323

Merged
chinmaygarde merged 1 commit into
flutter-team-archive:masterfrom
yuanhuihui:support_API_stream
Dec 11, 2019
Merged

Fix missing API stream when record event in systrace#14323
chinmaygarde merged 1 commit into
flutter-team-archive:masterfrom
yuanhuihui:support_API_stream

Conversation

@yuanhuihui

@yuanhuihui yuanhuihui commented Dec 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix missing API stream when record timeline event in systrace

For example, third_party/dart/runtime/vm/dart_api_impl.cc

DART_EXPORT void Dart_NotifyIdle(int64_t deadline) {
  Thread* T = Thread::Current();
  CHECK_ISOLATE(T->isolate());
  API_TIMELINE_BEGIN_END(T);
  TransitionNativeToVM transition(T);
  T->isolate()->NotifyIdle(deadline);
}

1）API_TIMELINE_BEGIN_END does not appear in systrace
4-1-systrace-No-API

2）with this PR, we can see Dart_NotifyIdle event in systrace
4-2-systrace-add-API

@yuanhuihui
Fix missing API stream when record event in systrace
c1c7e6a 
Signed-off-by: yuanhuihui <gityuan@gmail.com>
@auto-assign auto-assign Bot requested a review from franciscojma86 December 11, 2019 04:56
@chinmaygarde chinmaygarde merged commit 9dc23b8 into flutter-team-archive:master Dec 11, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2019
@engine-flutter-autoroll
9dc23b8 Fix missing API stream when record event in systrace (flutter…
c3503f5 
…-team-archive/engine#14323)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2019
@engine-flutter-autoroll
9dc23b8 Fix missing API stream when record event in systrace (flutter…
f29573f 
…-team-archive/engine#14323)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2019
@engine-flutter-autoroll
9dc23b8 Fix missing API stream when record event in systrace (flutter…
c2a2509 
…-team-archive/engine#14323)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2019
Merged
iskakaushik pushed a commit to flutter/flutter that referenced this pull request Dec 13, 2019
@engine-flutter-autoroll @iskakaushik
Roll engine db60ebc..e0e0ac0 (23 commits) (#46933)
67adb89 
* fb9dfe0 [fuchsia] Move async_get_default_dispatcher include to the header (flutter-team-archive/engine#14351)

* 3ebb7b4 Roll src/third_party/skia 75799967be60..3517aa7b14ad (3 commits) (flutter-team-archive/engine#14345)

* 2713225 Remove duplicate and outdated src/third_party/dart/tools/sdks entry from DEPS. (flutter-team-archive/engine#14340)

* 80d80ff Add ability to control dithering on Paint (flutter-team-archive/engine#13868)

* 8595361 Conditionally use offscreen root surface only when needed

* 0a40f3d Assert that arc end caps on canvases with root surface transformations are drawn correctly. (flutter-team-archive/engine#14359)

* d698d96 Fix missing timeline event of flutter engine's startup time (flutter-team-archive/engine#14319)

* 9dc23b8 Fix missing API stream when record event in systrace (flutter-team-archive/engine#14323)

* 9e4c6ad Fix CGMutablePathRef memory leaks when the path is invalid. (flutter-team-archive/engine#14275)

* fc8cafb objcdoc fix for some ambiguity (flutter-team-archive/engine#14367)

* 9bafb3c [tests] Use distinct begin and end times (flutter-team-archive/engine#14361)

* 897ce34 Roll src/third_party/skia 3517aa7b14ad..826484f2631f (18 commits) (flutter-team-archive/engine#14375)

* 1ce85be [flutter_runner] Enable Skia tracing by default on Fuchsia (flutter-team-archive/engine#13457)

* a7b6ee5 Smart quote/dash configuration support in iOS (flutter-team-archive/engine#13863)

* 48ba39c Roll fuchsia/sdk/core/mac-amd64 from otkJA... to SlgE8... (flutter-team-archive/engine#14407)

* 0081e8c Remove unused _TypeNone enum field. (flutter-team-archive/engine#14440)

* d8edfea Roll src/third_party/dart d9fa37e85d5c..45db29709547 (48 commits) (flutter-team-archive/engine#14453)

* f650bca Refactoring text editing. Strategy pattern is used to handle different browser/operating system and a11y behavior. (flutter-team-archive/engine#14131)

* 4275b49 Fix type in build_fuchsia_artifacts (flutter-team-archive/engine#14452)

* 0c24f3d Roll src/third_party/skia 51b99659ed82..c514e7d9be6e (13 commits) (flutter-team-archive/engine#14457)

* ffbe2a4 [testing] Move test vsync waiters to their own TUs (flutter-team-archive/engine#14456)

* 181ad4e Use futures to images used for comparison with fixtures in embedder unit-tests. (flutter-team-archive/engine#14465)

* e0e0ac0 [testing] Make vsync waiters pluggable in shell_unittests (flutter-team-archive/engine#14463)
@yuanhuihui yuanhuihui mentioned this pull request Dec 17, 2019
Merged
@yuanhuihui yuanhuihui mentioned this pull request Dec 25, 2019
Closed
@yuanhuihui

yuanhuihui commented Dec 25, 2019

Copy link
Copy Markdown
Contributor Author

relation to flutter/flutter#47771

filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@yuanhuihui @filmil
Fix missing API stream when record event in systrace (flutter-team-ar…
0f27c98 
…chive#14323)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@franciscojma86 franciscojma86 Awaiting requested review from franciscojma86
1 more reviewer
@chinmaygarde chinmaygarde chinmaygarde approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuanhuihui @chinmaygarde @googlebot