Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/web_ui/lib/src/engine/text_editing/text_editing.dart
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,15 @@ class InputConfiguration {
@required this.inputType,
@required this.inputAction,
@required this.obscureText,
@required this.autocorrect,
});

InputConfiguration.fromFlutter(Map<String, dynamic> flutterInputConfiguration)
: inputType = EngineInputType.fromName(
flutterInputConfiguration['inputType']['name']),
inputAction = flutterInputConfiguration['inputAction'],
obscureText = flutterInputConfiguration['obscureText'];
obscureText = flutterInputConfiguration['obscureText'],
autocorrect = flutterInputConfiguration['autocorrect'];
Comment thread
nturgut marked this conversation as resolved.

/// The type of information being edited in the input control.
final EngineInputType inputType;
Expand All @@ -195,6 +197,9 @@ class InputConfiguration {

/// Whether to hide the text being edited.
final bool obscureText;

/// Whether to to enable autocorrection. Only available on Webkit.
Comment thread
nturgut marked this conversation as resolved.
Outdated
final bool autocorrect;
Comment thread
nturgut marked this conversation as resolved.
}

typedef _OnChangeCallback = void Function(EditingState editingState);
Expand Down Expand Up @@ -372,6 +377,10 @@ class TextEditingElement {
if (inputConfig.obscureText) {
domElement.setAttribute('type', 'password');
}
if (browserEngine == BrowserEngine.webkit && inputConfig.autocorrect) {
Comment thread
nturgut marked this conversation as resolved.
Outdated
final String autocorrectValue = inputConfig.autocorrect ? 'on' : 'off';
domElement.setAttribute('autocorrect', autocorrectValue);
}
_setStaticStyleAttributes(domElement);
owner._setDynamicStyleAttributes(domElement);
domRenderer.glassPaneElement.append(domElement);
Expand Down
5 changes: 5 additions & 0 deletions lib/web_ui/test/text_editing_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ final InputConfiguration singlelineConfig = InputConfiguration(
inputType: EngineInputType.text,
obscureText: false,
inputAction: 'TextInputAction.done',
autocorrect: true,
);
final Map<String, dynamic> flutterSinglelineConfig =
createFlutterConfig('text');
Expand All @@ -34,6 +35,7 @@ final InputConfiguration multilineConfig = InputConfiguration(
inputType: EngineInputType.multiline,
obscureText: false,
inputAction: 'TextInputAction.newline',
autocorrect: true,
);
final Map<String, dynamic> flutterMultilineConfig =
createFlutterConfig('multiline');
Expand Down Expand Up @@ -105,6 +107,7 @@ void main() {
inputType: EngineInputType.text,
inputAction: 'TextInputAction.done',
obscureText: true,
autocorrect: true,
);
editingElement.enable(
config,
Expand Down Expand Up @@ -263,6 +266,7 @@ void main() {
inputType: EngineInputType.text,
obscureText: false,
inputAction: 'TextInputAction.done',
autocorrect: true,
);
editingElement.enable(
config,
Expand All @@ -286,6 +290,7 @@ void main() {
inputType: EngineInputType.multiline,
obscureText: false,
inputAction: 'TextInputAction.done',
autocorrect: true,
);
editingElement.enable(
config,
Expand Down