This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Manual roll of src/third_party/dart from ed1e0e199e to b28b9ae8fc1#13171
Closed
mkustermann wants to merge 1 commit into
Closed
Manual roll of src/third_party/dart from ed1e0e199e to b28b9ae8fc1#13171mkustermann wants to merge 1 commit into
mkustermann wants to merge 1 commit into
Conversation
dcharkes
approved these changes
Oct 16, 2019
dcharkes
left a comment
dcharkes
left a comment
Contributor
There was a problem hiding this comment.
dart_ffi_tag is not updated because it has been rolled already earlier today.
dart-lang/sdk@b28b9ae8fc Fix analyzer on windows dart-lang/sdk@504c45fe2b [CFE] Don't cleanup moved parts in uriToSource dart-lang/sdk@f3294f7083 [cfe] Ignore context when de-duplicating error messages dart-lang/sdk@ed1e0e199e [vm/ffi] Handle IntConverter's similar to LoadUntagged in load optimizer
mkustermann
changed the title
bkonyi
approved these changes
Oct 16, 2019
bkonyi
left a comment
bkonyi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but is there any particular reason for this manual roll? The autoroller should be able to pick this up in ~1 hour.
Contributor
|
The autoroller is picking up this commit range in PR #13178. |
Contributor
Author
The autoroller seemed to not have rolled in the last 24h and we wanted to get this in to unbreak golem. Good to know that it's rolling again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.