Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Unblock SIGPROF on flutter_tester start#12813

Merged
bkonyi merged 4 commits into
masterfrom
unblock_sigprof_flutter_tester
Oct 8, 2019
Merged

Unblock SIGPROF on flutter_tester start#12813
bkonyi merged 4 commits into
masterfrom
unblock_sigprof_flutter_tester

Conversation

@bkonyi

@bkonyi bkonyi commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

@chinmaygarde

Copy link
Copy Markdown
Contributor

Linux presubmits are mad.

@bkonyi

bkonyi commented Oct 7, 2019

Copy link
Copy Markdown
Contributor Author

Linux presubmits are mad.

Ah, looks like I did some refactoring and didn't rebuild... the signal.h include needed to be after a header which defines OS_POSIX.

Comment thread shell/testing/tester_main.cc Outdated
@bkonyi
bkonyi merged commit c19fc2f into master Oct 8, 2019
@bkonyi
bkonyi deleted the unblock_sigprof_flutter_tester branch October 8, 2019 22:13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 9, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 9, 2019
git@github.com:flutter/engine.git/compare/c635d70c7266...21b8224

git log c635d70..21b8224 --no-merges --oneline
2019-10-08 gspencergoog@users.noreply.github.com Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter-team-archive/engine#12746)
2019-10-08 dnfield@google.com Fix for a11y crash on iOS (flutter-team-archive/engine#12990)
2019-10-08 katelovett@google.com Link Semantics Typo (flutter-team-archive/engine#13009)
2019-10-08 ferhat@gmail.com [web] Add support for path transform (flutter-team-archive/engine#12794)
2019-10-08 jason-simmons@users.noreply.github.com Auto-formatter fixes for BUILD.gn files (flutter-team-archive/engine#13005)
2019-10-08 bkonyi@google.com Unblock SIGPROF on flutter_tester start (flutter-team-archive/engine#12813)
2019-10-08 mouad.debbar@gmail.com [web] Update the url when route is replaced (flutter-team-archive/engine#13003)
2019-10-08 katelovett@google.com Missing link flag (flutter-team-archive/engine#13001)
2019-10-08 30870216+gaaclarke@users.noreply.github.com Started setting our debug background task id to invalid after completion. (flutter-team-archive/engine#12999)
2019-10-08 ychris@google.com Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter-team-archive/engine#12695)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
git@github.com:flutter/engine.git/compare/c635d70c7266...21b8224

git log c635d70..21b8224 --no-merges --oneline
2019-10-08 gspencergoog@users.noreply.github.com Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter-team-archive/engine#12746)
2019-10-08 dnfield@google.com Fix for a11y crash on iOS (flutter-team-archive/engine#12990)
2019-10-08 katelovett@google.com Link Semantics Typo (flutter-team-archive/engine#13009)
2019-10-08 ferhat@gmail.com [web] Add support for path transform (flutter-team-archive/engine#12794)
2019-10-08 jason-simmons@users.noreply.github.com Auto-formatter fixes for BUILD.gn files (flutter-team-archive/engine#13005)
2019-10-08 bkonyi@google.com Unblock SIGPROF on flutter_tester start (flutter-team-archive/engine#12813)
2019-10-08 mouad.debbar@gmail.com [web] Update the url when route is replaced (flutter-team-archive/engine#13003)
2019-10-08 katelovett@google.com Missing link flag (flutter-team-archive/engine#13001)
2019-10-08 30870216+gaaclarke@users.noreply.github.com Started setting our debug background task id to invalid after completion. (flutter-team-archive/engine#12999)
2019-10-08 ychris@google.com Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter-team-archive/engine#12695)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

Observatory profiler doesn't seem to work

4 participants