Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/web_ui/lib/src/engine/text_editing.dart
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,9 @@ class TextEditingElement {
_subscriptions.add(domElement.onKeyUp.listen((event) {
_handleChange(event);
}));
/// In Firefox the context menu item "Select All" does not work without
/// listening onSelect. On the other browersers onSelectionChange is
Comment thread
nturgut marked this conversation as resolved.
Outdated
/// enough for covering "Select All" functionality.
_subscriptions.add(domElement.onSelect.listen(_handleChange));
Comment thread
nturgut marked this conversation as resolved.
} else {
_subscriptions.add(html.document.onSelectionChange.listen(_handleChange));
Expand Down
3 changes: 2 additions & 1 deletion lib/web_ui/test/text_editing_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ void main() {
expect(editingElement.domElement, input);

// Input is appended to the glass pane.
expect('${editingElement.domElement.parent.tagName}', 'FLT-GLASS-PANE');
expect(domRenderer.glassPaneElement.contains(editingElement.domElement),
isTrue);

editingElement.disable();
expect(
Expand Down