This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Added javadoc comments to FlutterActivity and FlutterFragmentActivity.#12328
Merged
matthew-carroll merged 2 commits intoSep 17, 2019
Merged
Conversation
xster
reviewed
Sep 17, 2019
| * /> | ||
| * } | ||
| * <p> | ||
| * A number of methods in this class have the same implementation as |
Contributor
There was a problem hiding this comment.
Should these be javadocs? I don't think people want to see it in https://api.flutter.dev/javadoc/ right? Maybe split this into 2 parts. Reference the other alternative in javadocs for users and leave a code comment for other maintainers.
Contributor
Author
There was a problem hiding this comment.
Sounds good. Made the changes.
Contributor
|
LGTM |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 18, 2019
git@github.com:flutter/engine.git/compare/6a96417416b4...36be89d git log 6a96417..36be89d --no-merges --oneline 2019-09-17 matthew-carroll@users.noreply.github.com Added javadoc comments to FlutterActivity and FlutterFragmentActivity. (flutter-team-archive/engine#12328) 2019-09-17 bkonyi@google.com Roll src/third_party/dart 7505b3a5f0..f22f62c85d (5 commits) 2019-09-17 iska.kaushik@gmail.com Revert "Provide dart vm initalize isolate callback so that children isolates belong to parent's isolate group. (#9888)" (flutter-team-archive/engine#12327) 2019-09-17 ankitdave06@gmail.com [flutter] Remove old A11y API's. (flutter-team-archive/engine#12308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/6a96417416b4...36be89d git log 6a96417..36be89d --no-merges --oneline 2019-09-17 matthew-carroll@users.noreply.github.com Added javadoc comments to FlutterActivity and FlutterFragmentActivity. (flutter-team-archive/engine#12328) 2019-09-17 bkonyi@google.com Roll src/third_party/dart 7505b3a5f0..f22f62c85d (5 commits) 2019-09-17 iska.kaushik@gmail.com Revert "Provide dart vm initalize isolate callback so that children isolates belong to parent's isolate group. (flutter#9888)" (flutter-team-archive/engine#12327) 2019-09-17 ankitdave06@gmail.com [flutter] Remove old A11y API's. (flutter-team-archive/engine#12308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added javadoc comments to FlutterActivity and FlutterFragmentActivity.